Mercurial > hg > xemacs-beta
comparison src/ChangeLog @ 5911:48386fd60fd0
GMP functions that take doubles choke on non-finite values, avoid that.
src/ChangeLog addition:
2015-05-10 Aidan Kehoe <kehoea@parhasard.net>
* floatfns.c (double_to_integer):
Rename this from float_to_int to fit our newer, bignum-compatible
terminology.
GMP can signal SIGFPE when asked to turn NaN or infinity into a
bignum, and we're not prepared to handle that signal if the OS float
library routines don't do that, so check for those values
explicitly.
* floatfns.c (ceiling_two_float):
* floatfns.c (ceiling_one_float):
* floatfns.c (floor_two_float):
* floatfns.c (floor_one_float):
* floatfns.c (round_two_float):
* floatfns.c (round_one_float):
* floatfns.c (truncate_two_float):
* floatfns.c (truncate_one_float):
Call double_to_integer() with its new name.
* number.c:
Don't use the {bignum,ratio,bigfloat}_set_double functions
directly here, with GMP they can choke when handed non-finite C
doubles, call Ftruncate() and the new float_to_bigfloat() from
floatfns.c. Maybe we should extend number-gmp.c with GMP-specific
implementations that check for non-finite values.
tests/ChangeLog addition:
2015-05-10 Aidan Kehoe <kehoea@parhasard.net>
* automated/lisp-tests.el:
Backslash a few parentheses in the first column for the sake of
fontification.
* automated/lisp-tests.el:
Check that the rounding functions signal Lisp errors correctly
when handed positive and negative infinity and NaN.
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Sun, 10 May 2015 19:07:09 +0100 |
| parents | eb1e15c9440b |
| children | 47ffa085a9ad |
comparison
equal
deleted
inserted
replaced
| 5910:eb1e15c9440b | 5911:48386fd60fd0 |
|---|---|
| 1 2015-05-10 Aidan Kehoe <kehoea@parhasard.net> | |
| 2 | |
| 3 * floatfns.c (double_to_integer): | |
| 4 Rename this from float_to_int to fit our newer, bignum-compatible | |
| 5 terminology. | |
| 6 GMP can signal SIGFPE when asked to turn NaN or infinity into a | |
| 7 bignum, and we're not prepared to handle that signal if the OS float | |
| 8 library routines don't do that, so check for those values | |
| 9 explicitly. | |
| 10 | |
| 11 * floatfns.c (ceiling_two_float): | |
| 12 * floatfns.c (ceiling_one_float): | |
| 13 * floatfns.c (floor_two_float): | |
| 14 * floatfns.c (floor_one_float): | |
| 15 * floatfns.c (round_two_float): | |
| 16 * floatfns.c (round_one_float): | |
| 17 * floatfns.c (truncate_two_float): | |
| 18 * floatfns.c (truncate_one_float): | |
| 19 Call double_to_integer() with its new name. | |
| 20 | |
| 21 * number.c: | |
| 22 Don't use the {bignum,ratio,bigfloat}_set_double functions | |
| 23 directly here, with GMP they can choke when handed non-finite C | |
| 24 doubles, call Ftruncate() and the new float_to_bigfloat() from | |
| 25 floatfns.c. Maybe we should extend number-gmp.c with GMP-specific | |
| 26 implementations that check for non-finite values. | |
| 27 | |
| 1 2015-05-09 Aidan Kehoe <kehoea@parhasard.net> | 28 2015-05-09 Aidan Kehoe <kehoea@parhasard.net> |
| 2 | 29 |
| 3 * data.c (Flogand): | 30 * data.c (Flogand): |
| 4 * data.c (Flogior): | 31 * data.c (Flogior): |
| 5 * data.c (Frem): | 32 * data.c (Frem): |
