Mercurial > hg > xemacs-beta
comparison src/event-unixoid.c @ 5016:2ade80e8c640
enable more warnings and fix them
-------------------- ChangeLog entries follow: --------------------
ChangeLog addition:
2010-02-08 Ben Wing <ben@xemacs.org>
* configure:
* configure.ac (TAB):
Various warnings that used to be present had mistakenly gotten
turned off. Turn them back on.
lwlib/ChangeLog addition:
2010-02-08 Ben Wing <ben@xemacs.org>
* xt-wrappers.h:
* xt-wrappers.h (Xt_SET_VALUE):
* xt-wrappers.h (Xt_GET_VALUE):
Rename var to avoid shadowing problems.
src/ChangeLog addition:
2010-02-08 Ben Wing <ben@xemacs.org>
* alloc.c:
Add prototypes for debugging functions.
* alloc.c (compact_string_chars): Make static.
* console-x.c (x_initially_selected_for_input):
* console-x.h:
* console-x.h (X_ERROR_OCCURRED):
Delete x_has_keysym() prototype from console-x.c, move to console-x.h.
* eval.c (multiple_value_call):
Real bug: Fix shadowing local vars.
* event-unixoid.c (read_event_from_tty_or_stream_desc):
* event-unixoid.c (signal_fake_event):
* lread.c (check_if_suppressed):
* strftime.c (strftime):
Fix stupid global shadowing warnings.
* event-unixoid.c (signal_fake_event):
* event-unixoid.c (drain_signal_event_pipe):
Use Rawbyte, not char.
* frame.h: Remove old prototype.
* gc.c:
* gc.c (show_gc_cursor_and_message):
* gc.c (remove_gc_cursor_and_message):
* gc.c (gc_prepare):
* gc.c (gc_finish_mark):
* gc.c (gc_finalize):
* gc.c (gc_sweep):
* gc.c (gc_finish):
* gc.c (gc_suspend_mark_phase):
* gc.c (gc_resume_mark_phase):
* gc.c (gc_mark):
* gc.c (gc_resume_mark):
Make fns static.
* glyphs-eimage.c (gif_decode_error_string):
Fix non-prototype.
* lisp.h:
Hack around global shadowing warnings involving `index'.
* intl-win32.c (wcsncpy):
* number-gmp.c (bigfloat_to_string):
* objects-msw.c (mswindows_font_spec_matches_charset_stage_2):
* specifier.c (call_charset_predicate):
* specifier.c (DEFINE_SPECIFIER_TAG_FROB):
Declarations cannot follow statements in standard C.
* search.c (search_buffer): Fix local shadowing warnings.
author | Ben Wing <ben@xemacs.org> |
---|---|
date | Mon, 08 Feb 2010 21:28:57 -0600 |
parents | 70e8a00896e9 |
children | 308d34e9f07d |
comparison
equal
deleted
inserted
replaced
5015:d95c102a96d3 | 5016:2ade80e8c640 |
---|---|
98 | 98 |
99 if (CONSOLE_TTY_P (con)) | 99 if (CONSOLE_TTY_P (con)) |
100 ch = Lstream_get_ichar (XLSTREAM (CONSOLE_TTY_DATA (con)->instream)); | 100 ch = Lstream_get_ichar (XLSTREAM (CONSOLE_TTY_DATA (con)->instream)); |
101 else | 101 else |
102 { | 102 { |
103 Ibyte byte; | 103 Ibyte ibyte; |
104 /* #### Definitely something strange here. We should be setting | 104 /* #### Definitely something strange here. We should be setting |
105 the stdio handle unbuffered and reading from it instead of mixing | 105 the stdio handle unbuffered and reading from it instead of mixing |
106 stdio and raw io calls. */ | 106 stdio and raw io calls. */ |
107 int nread = retry_read (fileno (CONSOLE_STREAM_DATA (con)->in), | 107 int nread = retry_read (fileno (CONSOLE_STREAM_DATA (con)->in), |
108 &byte, 1); | 108 &ibyte, 1); |
109 if (nread <= 0) | 109 if (nread <= 0) |
110 ch = -1; | 110 ch = -1; |
111 else | 111 else |
112 ch = byte; | 112 ch = ibyte; |
113 } | 113 } |
114 | 114 |
115 if (ch < 0) | 115 if (ch < 0) |
116 { | 116 { |
117 /* deleting the console might not be safe right now ... */ | 117 /* deleting the console might not be safe right now ... */ |
130 } | 130 } |
131 | 131 |
132 void | 132 void |
133 signal_fake_event (void) | 133 signal_fake_event (void) |
134 { | 134 { |
135 char byte = 0; | 135 Rawbyte rbyte = 0; |
136 /* We do the write always. Formerly I tried to "optimize" this | 136 /* We do the write always. Formerly I tried to "optimize" this |
137 by setting a flag indicating whether we're blocking and only | 137 by setting a flag indicating whether we're blocking and only |
138 doing the write in that case, but there is a race condition | 138 doing the write in that case, but there is a race condition |
139 if the signal occurs after we've checked for the signal | 139 if the signal occurs after we've checked for the signal |
140 occurrence (which could occur in many places throughout | 140 occurrence (which could occur in many places throughout |
146 | 146 |
147 if (signal_event_pipe_initialized) | 147 if (signal_event_pipe_initialized) |
148 /* In case a signal comes through while we're dumping */ | 148 /* In case a signal comes through while we're dumping */ |
149 { | 149 { |
150 int old_errno = errno; | 150 int old_errno = errno; |
151 retry_write (signal_event_pipe[1], &byte, 1); | 151 retry_write (signal_event_pipe[1], &rbyte, 1); |
152 errno = old_errno; | 152 errno = old_errno; |
153 } | 153 } |
154 } | 154 } |
155 | 155 |
156 void | 156 void |
157 drain_signal_event_pipe (void) | 157 drain_signal_event_pipe (void) |
158 { | 158 { |
159 char chars[128]; | 159 Rawbyte chars[128]; |
160 /* The input end of the pipe has been set to non-blocking. */ | 160 /* The input end of the pipe has been set to non-blocking. */ |
161 while (retry_read (signal_event_pipe[0], chars, sizeof (chars)) > 0) | 161 while (retry_read (signal_event_pipe[0], chars, sizeof (chars)) > 0) |
162 ; | 162 ; |
163 } | 163 } |
164 | 164 |