comparison src/ChangeLog @ 5157:1fae11d56ad2

redo memory-usage mechanism, add way of dynamically initializing Lisp objects -------------------- ChangeLog entries follow: -------------------- lisp/ChangeLog addition: 2010-03-18 Ben Wing <ben@xemacs.org> * diagnose.el (show-memory-usage): Rewrite to take into account API changes in memory-usage functions. src/ChangeLog addition: 2010-03-18 Ben Wing <ben@xemacs.org> * alloc.c: * alloc.c (disksave_object_finalization_1): * alloc.c (lisp_object_storage_size): * alloc.c (listu): * alloc.c (listn): * alloc.c (Fobject_memory_usage_stats): * alloc.c (compute_memusage_stats_length): * alloc.c (Fobject_memory_usage): * alloc.c (Ftotal_object_memory_usage): * alloc.c (malloced_storage_size): * alloc.c (common_init_alloc_early): * alloc.c (reinit_alloc_objects_early): * alloc.c (reinit_alloc_early): * alloc.c (init_alloc_once_early): * alloc.c (syms_of_alloc): * alloc.c (reinit_vars_of_alloc): * buffer.c: * buffer.c (struct buffer_stats): * buffer.c (compute_buffer_text_usage): * buffer.c (compute_buffer_usage): * buffer.c (buffer_memory_usage): * buffer.c (buffer_objects_create): * buffer.c (syms_of_buffer): * buffer.c (vars_of_buffer): * console-impl.h (struct console_methods): * dynarr.c (Dynarr_memory_usage): * emacs.c (main_1): * events.c (clear_event_resource): * extents.c: * extents.c (compute_buffer_extent_usage): * extents.c (extent_objects_create): * extents.h: * faces.c: * faces.c (compute_face_cachel_usage): * faces.c (face_objects_create): * faces.h: * general-slots.h: * glyphs.c: * glyphs.c (compute_glyph_cachel_usage): * glyphs.c (glyph_objects_create): * glyphs.h: * lisp.h: * lisp.h (struct usage_stats): * lrecord.h: * lrecord.h (enum lrecord_type): * lrecord.h (struct lrecord_implementation): * lrecord.h (MC_ALLOC_CALL_FINALIZER_FOR_DISKSAVE): * lrecord.h (DEFINE_DUMPABLE_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_SIZABLE_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_FROB_BLOCK_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_FROB_BLOCK_SIZABLE_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_INTERNAL_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_SIZABLE_INTERNAL_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_SIZABLE_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_FROB_BLOCK_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_FROB_BLOCK_SIZABLE_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_INTERNAL_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_SIZABLE_INTERNAL_LISP_OBJECT): * lrecord.h (MAKE_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_MODULE_LISP_OBJECT): * lrecord.h (DEFINE_DUMPABLE_MODULE_SIZABLE_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_MODULE_LISP_OBJECT): * lrecord.h (DEFINE_NODUMP_MODULE_SIZABLE_LISP_OBJECT): * lrecord.h (MAKE_MODULE_LISP_OBJECT): * lrecord.h (INIT_LISP_OBJECT): * lrecord.h (INIT_MODULE_LISP_OBJECT): * lrecord.h (UNDEF_LISP_OBJECT): * lrecord.h (UNDEF_MODULE_LISP_OBJECT): * lrecord.h (DECLARE_LISP_OBJECT): * lrecord.h (DECLARE_MODULE_API_LISP_OBJECT): * lrecord.h (DECLARE_MODULE_LISP_OBJECT): * lstream.c: * lstream.c (syms_of_lstream): * lstream.c (vars_of_lstream): * marker.c: * marker.c (compute_buffer_marker_usage): * mc-alloc.c (mc_alloced_storage_size): * mc-alloc.h: * mule-charset.c: * mule-charset.c (struct charset_stats): * mule-charset.c (compute_charset_usage): * mule-charset.c (charset_memory_usage): * mule-charset.c (mule_charset_objects_create): * mule-charset.c (syms_of_mule_charset): * mule-charset.c (vars_of_mule_charset): * redisplay.c: * redisplay.c (compute_rune_dynarr_usage): * redisplay.c (compute_display_block_dynarr_usage): * redisplay.c (compute_glyph_block_dynarr_usage): * redisplay.c (compute_display_line_dynarr_usage): * redisplay.c (compute_line_start_cache_dynarr_usage): * redisplay.h: * scrollbar-gtk.c (gtk_compute_scrollbar_instance_usage): * scrollbar-msw.c (mswindows_compute_scrollbar_instance_usage): * scrollbar-x.c (x_compute_scrollbar_instance_usage): * scrollbar.c (compute_scrollbar_instance_usage): * scrollbar.h: * symbols.c: * symbols.c (reinit_symbol_objects_early): * symbols.c (init_symbols_once_early): * symbols.c (reinit_symbols_early): * symbols.c (defsymbol_massage_name_1): * symsinit.h: * ui-gtk.c: * ui-gtk.c (emacs_gtk_object_getprop): * ui-gtk.c (emacs_gtk_object_putprop): * ui-gtk.c (ui_gtk_objects_create): * unicode.c (compute_from_unicode_table_size_1): * unicode.c (compute_to_unicode_table_size_1): * unicode.c (compute_from_unicode_table_size): * unicode.c (compute_to_unicode_table_size): * window.c: * window.c (struct window_stats): * window.c (compute_window_mirror_usage): * window.c (compute_window_usage): * window.c (window_memory_usage): * window.c (window_objects_create): * window.c (syms_of_window): * window.c (vars_of_window): * window.h: Redo memory-usage mechanism, make it general; add way of dynamically initializing Lisp object types -- OBJECT_HAS_METHOD(), similar to CONSOLE_HAS_METHOD(). (1) Create OBJECT_HAS_METHOD(), OBJECT_HAS_PROPERTY() etc. for specifying that a Lisp object type has a particular method or property. Call such methods with OBJECT_METH, MAYBE_OBJECT_METH, OBJECT_METH_OR_GIVEN; retrieve properties with OBJECT_PROPERTY. Methods that formerly required a DEFINE_*GENERAL_LISP_OBJECT() to specify them (getprop, putprop, remprop, plist, disksave) now instead use the dynamic-method mechanism. The main benefit of this is that new methods or properties can be added without requiring that the declaration statements of all existing methods be modified. We have to make the `struct lrecord_implementation' non-const, but I don't think this should have any effect on speed -- the only possible method that's really speed-critical is the mark method, and we already extract those out into a separate (non-const) array for increased cache locality. Object methods need to be reinitialized after pdump, so we put them in separate functions such as face_objects_create(), extent_objects_create() and call them appropriately from emacs.c The only current object property (`memusage_stats_list') that objects can specify is a Lisp object and gets staticpro()ed so it only needs to be set during dump time, but because it references symbols that might not exist in a syms_of_() function, we initialize it in vars_of_(). There is also an object property (`num_extra_memusage_stats') that is automatically initialized based on `memusage_stats_list'; we do that in reinit_vars_of_alloc(), which is called after all vars_of_() functions are called. `disksaver' method was renamed `disksave' to correspond with the name normally given to the function (e.g. disksave_lstream()). (2) Generalize the memory-usage mechanism in `buffer-memory-usage', `window-memory-usage', `charset-memory-usage' into an object-type- specific mechanism called by a single function `object-memory-usage'. (Former function `object-memory-usage' renamed to `total-object-memory-usage'). Generalize the mechanism of different "slices" so that we can have different "classes" of memory described and different "slices" onto each class; `t' separates classes, `nil' separates slices. Currently we have three classes defined: the memory of an object itself, non-Lisp-object memory associated with the object (e.g. arrays or dynarrs stored as fields in the object), and Lisp-object memory associated with the object (other internal Lisp objects stored in the object). This isn't completely finished yet and we might need to further separate the "other internal Lisp objects" class into two classes. The memory-usage mechanism uses a `struct usage_stats' (renamed from `struct overhead_stats') to describe a malloc-view onto a set of allocated memory (listing how much was requested and various types of overhead) and a more general `struct generic_usage_stats' (with a `struct usage_stats' in it) to hold all statistics about object memory. `struct generic_usage_stats' contains an array of 32 Bytecounts, which are statistics of unspecified semantics. The intention is that individual types declare a corresponding struct (e.g. `struct window_stats') with the same structure but with specific fields in place of the array, corresponding to specific statistics. The number of such statistics is an object property computed from the list of tags (Lisp symbols describing the statistics) stored in `memusage_stats_list'. The idea here is to allow particular object types to customize the number and semantics of the statistics where completely avoiding consing. This doesn't matter so much yet, but the intention is to have the memory usage of all objects computed at the end of GC, at the same time as other statistics are currently computed. The values for all statistics for a single type would be added up to compute aggregate values for all objects of a specific type. To make this efficient, we can't allow any memory allocation at all. (3) Create some additional functions for creating lists that specify the elements directly as args rather than indirectly through an array: listn() (number of args given), listu() (list terminated by Qunbound). (4) Delete a bit of remaining unused C window_config stuff, also unused lrecord_type_popup_data.
author Ben Wing <ben@xemacs.org>
date Thu, 18 Mar 2010 10:50:06 -0500
parents 6bff4f219697
children 9e0b43d3095c
comparison
equal deleted inserted replaced
5156:6bff4f219697 5157:1fae11d56ad2
1 2010-03-18 Ben Wing <ben@xemacs.org>
2
3 * alloc.c:
4 * alloc.c (disksave_object_finalization_1):
5 * alloc.c (lisp_object_storage_size):
6 * alloc.c (listu):
7 * alloc.c (listn):
8 * alloc.c (Fobject_memory_usage_stats):
9 * alloc.c (compute_memusage_stats_length):
10 * alloc.c (Fobject_memory_usage):
11 * alloc.c (Ftotal_object_memory_usage):
12 * alloc.c (malloced_storage_size):
13 * alloc.c (common_init_alloc_early):
14 * alloc.c (reinit_alloc_objects_early):
15 * alloc.c (reinit_alloc_early):
16 * alloc.c (init_alloc_once_early):
17 * alloc.c (syms_of_alloc):
18 * alloc.c (reinit_vars_of_alloc):
19 * buffer.c:
20 * buffer.c (struct buffer_stats):
21 * buffer.c (compute_buffer_text_usage):
22 * buffer.c (compute_buffer_usage):
23 * buffer.c (buffer_memory_usage):
24 * buffer.c (buffer_objects_create):
25 * buffer.c (syms_of_buffer):
26 * buffer.c (vars_of_buffer):
27 * console-impl.h (struct console_methods):
28 * dynarr.c (Dynarr_memory_usage):
29 * emacs.c (main_1):
30 * events.c (clear_event_resource):
31 * extents.c:
32 * extents.c (compute_buffer_extent_usage):
33 * extents.c (extent_objects_create):
34 * extents.h:
35 * faces.c:
36 * faces.c (compute_face_cachel_usage):
37 * faces.c (face_objects_create):
38 * faces.h:
39 * general-slots.h:
40 * glyphs.c:
41 * glyphs.c (compute_glyph_cachel_usage):
42 * glyphs.c (glyph_objects_create):
43 * glyphs.h:
44 * lisp.h:
45 * lisp.h (struct usage_stats):
46 * lrecord.h:
47 * lrecord.h (enum lrecord_type):
48 * lrecord.h (struct lrecord_implementation):
49 * lrecord.h (MC_ALLOC_CALL_FINALIZER_FOR_DISKSAVE):
50 * lrecord.h (DEFINE_DUMPABLE_LISP_OBJECT):
51 * lrecord.h (DEFINE_DUMPABLE_SIZABLE_LISP_OBJECT):
52 * lrecord.h (DEFINE_DUMPABLE_FROB_BLOCK_LISP_OBJECT):
53 * lrecord.h (DEFINE_DUMPABLE_FROB_BLOCK_SIZABLE_LISP_OBJECT):
54 * lrecord.h (DEFINE_DUMPABLE_INTERNAL_LISP_OBJECT):
55 * lrecord.h (DEFINE_DUMPABLE_SIZABLE_INTERNAL_LISP_OBJECT):
56 * lrecord.h (DEFINE_NODUMP_LISP_OBJECT):
57 * lrecord.h (DEFINE_NODUMP_SIZABLE_LISP_OBJECT):
58 * lrecord.h (DEFINE_NODUMP_FROB_BLOCK_LISP_OBJECT):
59 * lrecord.h (DEFINE_NODUMP_FROB_BLOCK_SIZABLE_LISP_OBJECT):
60 * lrecord.h (DEFINE_NODUMP_INTERNAL_LISP_OBJECT):
61 * lrecord.h (DEFINE_NODUMP_SIZABLE_INTERNAL_LISP_OBJECT):
62 * lrecord.h (MAKE_LISP_OBJECT):
63 * lrecord.h (DEFINE_DUMPABLE_MODULE_LISP_OBJECT):
64 * lrecord.h (DEFINE_DUMPABLE_MODULE_SIZABLE_LISP_OBJECT):
65 * lrecord.h (DEFINE_NODUMP_MODULE_LISP_OBJECT):
66 * lrecord.h (DEFINE_NODUMP_MODULE_SIZABLE_LISP_OBJECT):
67 * lrecord.h (MAKE_MODULE_LISP_OBJECT):
68 * lrecord.h (INIT_LISP_OBJECT):
69 * lrecord.h (INIT_MODULE_LISP_OBJECT):
70 * lrecord.h (UNDEF_LISP_OBJECT):
71 * lrecord.h (UNDEF_MODULE_LISP_OBJECT):
72 * lrecord.h (DECLARE_LISP_OBJECT):
73 * lrecord.h (DECLARE_MODULE_API_LISP_OBJECT):
74 * lrecord.h (DECLARE_MODULE_LISP_OBJECT):
75 * lstream.c:
76 * lstream.c (syms_of_lstream):
77 * lstream.c (vars_of_lstream):
78 * marker.c:
79 * marker.c (compute_buffer_marker_usage):
80 * mc-alloc.c (mc_alloced_storage_size):
81 * mc-alloc.h:
82 * mule-charset.c:
83 * mule-charset.c (struct charset_stats):
84 * mule-charset.c (compute_charset_usage):
85 * mule-charset.c (charset_memory_usage):
86 * mule-charset.c (mule_charset_objects_create):
87 * mule-charset.c (syms_of_mule_charset):
88 * mule-charset.c (vars_of_mule_charset):
89 * redisplay.c:
90 * redisplay.c (compute_rune_dynarr_usage):
91 * redisplay.c (compute_display_block_dynarr_usage):
92 * redisplay.c (compute_glyph_block_dynarr_usage):
93 * redisplay.c (compute_display_line_dynarr_usage):
94 * redisplay.c (compute_line_start_cache_dynarr_usage):
95 * redisplay.h:
96 * scrollbar-gtk.c (gtk_compute_scrollbar_instance_usage):
97 * scrollbar-msw.c (mswindows_compute_scrollbar_instance_usage):
98 * scrollbar-x.c (x_compute_scrollbar_instance_usage):
99 * scrollbar.c (compute_scrollbar_instance_usage):
100 * scrollbar.h:
101 * symbols.c:
102 * symbols.c (reinit_symbol_objects_early):
103 * symbols.c (init_symbols_once_early):
104 * symbols.c (reinit_symbols_early):
105 * symbols.c (defsymbol_massage_name_1):
106 * symsinit.h:
107 * ui-gtk.c:
108 * ui-gtk.c (emacs_gtk_object_getprop):
109 * ui-gtk.c (emacs_gtk_object_putprop):
110 * ui-gtk.c (ui_gtk_objects_create):
111 * unicode.c (compute_from_unicode_table_size_1):
112 * unicode.c (compute_to_unicode_table_size_1):
113 * unicode.c (compute_from_unicode_table_size):
114 * unicode.c (compute_to_unicode_table_size):
115 * window.c:
116 * window.c (struct window_stats):
117 * window.c (compute_window_mirror_usage):
118 * window.c (compute_window_usage):
119 * window.c (window_memory_usage):
120 * window.c (window_objects_create):
121 * window.c (syms_of_window):
122 * window.c (vars_of_window):
123 * window.h:
124 Redo memory-usage mechanism, make it general; add way of dynamically
125 initializing Lisp object types -- OBJECT_HAS_METHOD(), similar to
126 CONSOLE_HAS_METHOD().
127
128 (1) Create OBJECT_HAS_METHOD(), OBJECT_HAS_PROPERTY() etc. for
129 specifying that a Lisp object type has a particular method or
130 property. Call such methods with OBJECT_METH, MAYBE_OBJECT_METH,
131 OBJECT_METH_OR_GIVEN; retrieve properties with OBJECT_PROPERTY.
132 Methods that formerly required a DEFINE_*GENERAL_LISP_OBJECT() to
133 specify them (getprop, putprop, remprop, plist, disksave) now
134 instead use the dynamic-method mechanism. The main benefit of
135 this is that new methods or properties can be added without
136 requiring that the declaration statements of all existing methods
137 be modified. We have to make the `struct lrecord_implementation'
138 non-const, but I don't think this should have any effect on speed --
139 the only possible method that's really speed-critical is the
140 mark method, and we already extract those out into a separate
141 (non-const) array for increased cache locality.
142
143 Object methods need to be reinitialized after pdump, so we put
144 them in separate functions such as face_objects_create(),
145 extent_objects_create() and call them appropriately from emacs.c
146 The only current object property (`memusage_stats_list') that
147 objects can specify is a Lisp object and gets staticpro()ed so it
148 only needs to be set during dump time, but because it references
149 symbols that might not exist in a syms_of_() function, we
150 initialize it in vars_of_(). There is also an object property
151 (`num_extra_memusage_stats') that is automatically initialized based
152 on `memusage_stats_list'; we do that in reinit_vars_of_alloc(),
153 which is called after all vars_of_() functions are called.
154
155 `disksaver' method was renamed `disksave' to correspond with the
156 name normally given to the function (e.g. disksave_lstream()).
157
158 (2) Generalize the memory-usage mechanism in `buffer-memory-usage',
159 `window-memory-usage', `charset-memory-usage' into an object-type-
160 specific mechanism called by a single function
161 `object-memory-usage'. (Former function `object-memory-usage'
162 renamed to `total-object-memory-usage'). Generalize the mechanism
163 of different "slices" so that we can have different "classes" of
164 memory described and different "slices" onto each class; `t'
165 separates classes, `nil' separates slices. Currently we have
166 three classes defined: the memory of an object itself,
167 non-Lisp-object memory associated with the object (e.g. arrays or
168 dynarrs stored as fields in the object), and Lisp-object memory
169 associated with the object (other internal Lisp objects stored in
170 the object). This isn't completely finished yet and we might need
171 to further separate the "other internal Lisp objects" class into
172 two classes.
173
174 The memory-usage mechanism uses a `struct usage_stats' (renamed
175 from `struct overhead_stats') to describe a malloc-view onto a set
176 of allocated memory (listing how much was requested and various
177 types of overhead) and a more general `struct generic_usage_stats'
178 (with a `struct usage_stats' in it) to hold all statistics about
179 object memory. `struct generic_usage_stats' contains an array of
180 32 Bytecounts, which are statistics of unspecified semantics. The
181 intention is that individual types declare a corresponding struct
182 (e.g. `struct window_stats') with the same structure but with
183 specific fields in place of the array, corresponding to specific
184 statistics. The number of such statistics is an object property
185 computed from the list of tags (Lisp symbols describing the
186 statistics) stored in `memusage_stats_list'. The idea here is to
187 allow particular object types to customize the number and
188 semantics of the statistics where completely avoiding consing.
189 This doesn't matter so much yet, but the intention is to have the
190 memory usage of all objects computed at the end of GC, at the same
191 time as other statistics are currently computed. The values for
192 all statistics for a single type would be added up to compute
193 aggregate values for all objects of a specific type. To make this
194 efficient, we can't allow any memory allocation at all.
195
196 (3) Create some additional functions for creating lists that
197 specify the elements directly as args rather than indirectly through
198 an array: listn() (number of args given), listu() (list terminated
199 by Qunbound).
200
201 (4) Delete a bit of remaining unused C window_config stuff, also
202 unused lrecord_type_popup_data.
203
204
1 2010-03-18 Ben Wing <ben@xemacs.org> 205 2010-03-18 Ben Wing <ben@xemacs.org>
2 206
3 * tests.c: 207 * tests.c:
4 * tests.c (Ftest_data_format_conversion): 208 * tests.c (Ftest_data_format_conversion):
5 Need to GCPRO newly created objects or we'll eventually get 209 Need to GCPRO newly created objects or we'll eventually get