comparison tests/automated/os-tests.el @ 5576:071b810ceb18

Declare labels as line where appropriate; use #'labels, not #'flet, tests. lisp/ChangeLog addition: 2011-10-03 Aidan Kehoe <kehoea@parhasard.net> * simple.el (handle-pre-motion-command-current-command-is-motion): Implement #'keysyms-equal with #'labels + (declare (inline ...)), instead of abusing macrolet to the same end. * specifier.el (let-specifier): * mule/mule-cmds.el (describe-language-environment): * mule/mule-cmds.el (set-language-environment-coding-systems): * mule/mule-x-init.el (x-use-halfwidth-roman-font): * faces.el (Face-frob-property): * keymap.el (key-sequence-list-description): * lisp-mode.el (construct-lisp-mode-menu): * loadhist.el (unload-feature): * mouse.el (default-mouse-track-check-for-activation): Declare various labels inline in dumped files when that reduces the size of the dumped image. Declaring labels inline is normally only worthwhile for inner loops and so on, but it's reasonable exercise of the related code to have these changes in core. tests/ChangeLog addition: 2011-10-03 Aidan Kehoe <kehoea@parhasard.net> * automated/case-tests.el (uni-mappings): * automated/database-tests.el (delete-database-files): * automated/hash-table-tests.el (iterations): * automated/lisp-tests.el (test1): * automated/lisp-tests.el (a): * automated/lisp-tests.el (cl-floor): * automated/lisp-tests.el (foo): * automated/lisp-tests.el (list-nreverse): * automated/lisp-tests.el (needs-lexical-context): * automated/mule-tests.el (featurep): * automated/os-tests.el (original-string): * automated/os-tests.el (with): * automated/symbol-tests.el (check-weak-list-unique): Replace #'flet with #'labels where appropriate in these tests, following my own advice on style in the docstrings of those functions.
author Aidan Kehoe <kehoea@parhasard.net>
date Mon, 03 Oct 2011 20:16:14 +0100
parents eed303fac325
children c608d4b0b75e
comparison
equal deleted inserted replaced
5575:89cb6a66a61f 5576:071b810ceb18
60 tac process output." 60 tac process output."
61 (setq cases tac-cases) 61 (setq cases tac-cases)
62 (while cases 62 (while cases
63 (setq case (car cases) 63 (setq case (car cases)
64 cases (cdr cases)) 64 cases (cdr cases))
65 (flet ((do-test (pos result) 65 (labels ((do-test (pos result)
66 (erase-buffer) 66 (erase-buffer)
67 (insert original-string) 67 (insert original-string)
68 (goto-char pos) 68 (goto-char pos)
69 (call-process-region 3 7 "tac" t t) 69 (call-process-region 3 7 "tac" t t)
70 (goto-char (point-min)) 70 (goto-char (point-min))
71 (Assert (looking-at result)))) 71 (Assert (looking-at result))))
72 (do-test (car case) (cdr case))))) 72 (do-test (car case) (cdr case)))))
73 ;; if you're in that much of a hurry you can blow cat off 73 ;; if you're in that much of a hurry you can blow cat off
74 ;; if you've done tac, but I'm not going to bother 74 ;; if you've done tac, but I'm not going to bother
75 (Skip-Test-Unless cat-cases 75 (Skip-Test-Unless cat-cases
76 "cat executable not found" 76 "cat executable not found"
78 cat process output." 78 cat process output."
79 (setq cases cat-cases) 79 (setq cases cat-cases)
80 (while cases 80 (while cases
81 (setq case (car cases) 81 (setq case (car cases)
82 cases (cdr cases)) 82 cases (cdr cases))
83 (flet ((do-test (pos result) 83 (labels ((do-test (pos result)
84 (erase-buffer) 84 (erase-buffer)
85 (insert original-string) 85 (insert original-string)
86 (goto-char pos) 86 (goto-char pos)
87 (call-process-region 3 7 "cat" t t) 87 (call-process-region 3 7 "cat" t t)
88 (goto-char (point-min)) 88 (goto-char (point-min))
89 (Assert (looking-at result)))) 89 (Assert (looking-at result))))
90 (do-test (car case) (cdr case))))))) 90 (do-test (car case) (cdr case)))))))
91 91
92 (loop 92 (loop
93 with envvar-not-existing = (symbol-name (gensym "whatever")) 93 with envvar-not-existing = (symbol-name (gensym "whatever"))
94 with envvar-existing = (symbol-name (gensym "whatever")) 94 with envvar-existing = (symbol-name (gensym "whatever"))