comparison lisp/lisp-mode.el @ 5576:071b810ceb18

Declare labels as line where appropriate; use #'labels, not #'flet, tests. lisp/ChangeLog addition: 2011-10-03 Aidan Kehoe <kehoea@parhasard.net> * simple.el (handle-pre-motion-command-current-command-is-motion): Implement #'keysyms-equal with #'labels + (declare (inline ...)), instead of abusing macrolet to the same end. * specifier.el (let-specifier): * mule/mule-cmds.el (describe-language-environment): * mule/mule-cmds.el (set-language-environment-coding-systems): * mule/mule-x-init.el (x-use-halfwidth-roman-font): * faces.el (Face-frob-property): * keymap.el (key-sequence-list-description): * lisp-mode.el (construct-lisp-mode-menu): * loadhist.el (unload-feature): * mouse.el (default-mouse-track-check-for-activation): Declare various labels inline in dumped files when that reduces the size of the dumped image. Declaring labels inline is normally only worthwhile for inner loops and so on, but it's reasonable exercise of the related code to have these changes in core. tests/ChangeLog addition: 2011-10-03 Aidan Kehoe <kehoea@parhasard.net> * automated/case-tests.el (uni-mappings): * automated/database-tests.el (delete-database-files): * automated/hash-table-tests.el (iterations): * automated/lisp-tests.el (test1): * automated/lisp-tests.el (a): * automated/lisp-tests.el (cl-floor): * automated/lisp-tests.el (foo): * automated/lisp-tests.el (list-nreverse): * automated/lisp-tests.el (needs-lexical-context): * automated/mule-tests.el (featurep): * automated/os-tests.el (original-string): * automated/os-tests.el (with): * automated/symbol-tests.el (check-weak-list-unique): Replace #'flet with #'labels where appropriate in these tests, following my own advice on style in the docstrings of those functions.
author Aidan Kehoe <kehoea@parhasard.net>
date Mon, 03 Oct 2011 20:16:14 +0100
parents 3bc58dc9d688
children
comparison
equal deleted inserted replaced
5575:89cb6a66a61f 5576:071b810ceb18
43 (defvar lisp-mode-abbrev-table nil) 43 (defvar lisp-mode-abbrev-table nil)
44 44
45 (defun construct-lisp-mode-menu (popup-p emacs-lisp-p) 45 (defun construct-lisp-mode-menu (popup-p emacs-lisp-p)
46 (labels ((popup-wrap (form) 46 (labels ((popup-wrap (form)
47 (if popup-p `(menu-call-at-event ',form) form))) 47 (if popup-p `(menu-call-at-event ',form) form)))
48 (declare (inline popup-wrap))
48 `(,@(if emacs-lisp-p 49 `(,@(if emacs-lisp-p
49 `(["%_Byte-Compile This File" ,(popup-wrap 50 `(["%_Byte-Compile This File" ,(popup-wrap
50 'emacs-lisp-byte-compile)] 51 'emacs-lisp-byte-compile)]
51 ["B%_yte-Compile/Load This File" 52 ["B%_yte-Compile/Load This File"
52 ,(popup-wrap 'emacs-lisp-byte-compile-and-load)] 53 ,(popup-wrap 'emacs-lisp-byte-compile-and-load)]