Mercurial > hg > xemacs-beta
annotate src/widget.c @ 5366:f00192e1cd49
Examining the result of #'length: `eql', not `=', it's better style & cheaper
2011-03-08 Aidan Kehoe <kehoea@parhasard.net>
* buff-menu.el (list-buffers-noselect):
* byte-optimize.el (byte-optimize-identity):
* byte-optimize.el (byte-optimize-if):
* byte-optimize.el (byte-optimize-nth):
* byte-optimize.el (byte-optimize-nthcdr):
* bytecomp.el (byte-compile-warn-wrong-args):
* bytecomp.el (byte-compile-two-args-19->20):
* bytecomp.el (byte-compile-list):
* bytecomp.el (byte-compile-beginning-of-line):
* bytecomp.el (byte-compile-set):
* bytecomp.el (byte-compile-set-default):
* bytecomp.el (byte-compile-values):
* bytecomp.el (byte-compile-values-list):
* bytecomp.el (byte-compile-integerp):
* bytecomp.el (byte-compile-multiple-value-list-internal):
* bytecomp.el (byte-compile-throw):
* cl-macs.el (cl-do-arglist):
* cl-macs.el (cl-parse-loop-clause):
* cl-macs.el (multiple-value-bind):
* cl-macs.el (multiple-value-setq):
* cl-macs.el (get-setf-method):
* cmdloop.el (command-error):
* cmdloop.el (y-or-n-p-minibuf):
* cmdloop.el (yes-or-no-p-minibuf):
* coding.el (unencodable-char-position):
* cus-edit.el (custom-face-prompt):
* cus-edit.el (custom-buffer-create-internal):
* cus-edit.el (widget-face-action):
* cus-edit.el (custom-group-value-create):
* descr-text.el (describe-char-unicode-data):
* dialog-gtk.el (popup-builtin-question-dialog):
* dragdrop.el (experimental-dragdrop-drop-log-function):
* dragdrop.el (experimental-dragdrop-drop-mime-default):
* easymenu.el (easy-menu-add):
* easymenu.el (easy-menu-remove):
* faces.el (read-face-name):
* faces.el (set-face-stipple):
* files.el (file-name-non-special):
* font.el (font-combine-fonts):
* font.el (font-set-face-font):
* font.el (font-parse-rgb-components):
* font.el (font-rgb-color-p):
* font.el (font-color-rgb-components):
* gnuserv.el (gnuserv-edit-files):
* help.el (key-or-menu-binding):
* help.el (function-documentation-1):
* help.el (function-documentation):
* info.el (info):
* isearch-mode.el (isearch-exit):
* isearch-mode.el (isearch-edit-string):
* isearch-mode.el (isearch-*-char):
* isearch-mode.el (isearch-complete1):
* ldap.el (ldap-encode-country-string):
* ldap.el (ldap-decode-string):
* minibuf.el (read-file-name-internal-1):
* minibuf.el (read-non-nil-coding-system):
* minibuf.el (get-user-response):
* mouse.el (drag-window-divider):
* mule/ccl.el:
* mule/ccl.el (ccl-compile-if):
* mule/ccl.el (ccl-compile-break):
* mule/ccl.el (ccl-compile-repeat):
* mule/ccl.el (ccl-compile-write-repeat):
* mule/ccl.el (ccl-compile-call):
* mule/ccl.el (ccl-compile-end):
* mule/ccl.el (ccl-compile-read-multibyte-character):
* mule/ccl.el (ccl-compile-write-multibyte-character):
* mule/ccl.el (ccl-compile-translate-character):
* mule/ccl.el (ccl-compile-mule-to-unicode):
* mule/ccl.el (ccl-compile-unicode-to-mule):
* mule/ccl.el (ccl-compile-lookup-integer):
* mule/ccl.el (ccl-compile-lookup-character):
* mule/ccl.el (ccl-compile-map-multiple):
* mule/ccl.el (ccl-compile-map-single):
* mule/devan-util.el (devanagari-compose-to-one-glyph):
* mule/devan-util.el (devanagari-composition-component):
* mule/mule-cmds.el (finish-set-language-environment):
* mule/viet-util.el:
* mule/viet-util.el (viet-encode-viscii-char):
* multicast.el (open-multicast-group):
* newcomment.el (comment-quote-nested):
* newcomment.el (comment-region):
* newcomment.el (comment-dwim):
* regexp-opt.el (regexp-opt-group):
* replace.el (map-query-replace-regexp):
* specifier.el (derive-device-type-from-tag-set):
* subr.el (skip-chars-quote):
* test-harness.el (test-harness-from-buffer):
* test-harness.el (batch-test-emacs):
* wid-edit.el (widget-choice-action):
* wid-edit.el (widget-symbol-prompt-internal):
* wid-edit.el (widget-color-action):
* window-xemacs.el (push-window-configuration):
* window-xemacs.el (pop-window-configuration):
* window.el (quit-window):
* x-compose.el (electric-diacritic):
It's better style, and cheaper (often one assembler instruction
vs. a C funcall in the byte code), to use `eql' instead of `='
when it's clear what numerical type a given result will be. Change
much of our code to do this, with the help of a byte-compiler
change (not comitted) that looked for calls to #'length (which
always returns an integer) in its args.
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Tue, 08 Mar 2011 23:41:52 +0000 |
| parents | 80cd90837ac5 |
| children | 308d34e9f07d |
| rev | line source |
|---|---|
| 428 | 1 /* Primitives for work of the "widget" library. |
| 2 Copyright (C) 1997 Free Software Foundation, Inc. | |
| 3 | |
| 4 This file is part of XEmacs. | |
| 5 | |
| 6 XEmacs is free software; you can redistribute it and/or modify it | |
| 7 under the terms of the GNU General Public License as published by the | |
| 8 Free Software Foundation; either version 2, or (at your option) any | |
| 9 later version. | |
| 10 | |
| 11 XEmacs is distributed in the hope that it will be useful, but WITHOUT | |
| 12 ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 13 FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 14 for more details. | |
| 15 | |
| 16 You should have received a copy of the GNU General Public License | |
| 17 along with XEmacs; see the file COPYING. If not, write to | |
| 18 the Free Software Foundation, Inc., 59 Temple Place - Suite 330, | |
| 19 Boston, MA 02111-1307, USA. */ | |
| 20 | |
| 21 /* Synched up with: Not in FSF. */ | |
| 22 | |
| 23 /* In an ideal world, this file would not have been necessary. | |
| 24 However, elisp function calls being as slow as they are, it turns | |
| 25 out that some functions in the widget library (wid-edit.el) are the | |
| 26 bottleneck of Widget operation. Here is their translation to C, | |
| 27 for the sole reason of efficiency. */ | |
| 28 | |
| 29 #include <config.h> | |
| 30 #include "lisp.h" | |
| 31 #include "buffer.h" | |
| 32 | |
| 33 | |
| 34 Lisp_Object Qwidget_type; | |
| 35 | |
| 36 | |
| 37 DEFUN ("widget-plist-member", Fwidget_plist_member, 2, 2, 0, /* | |
| 38 Like `plist-get', but returns the tail of PLIST whose car is PROP. | |
| 39 */ | |
| 40 (plist, prop)) | |
| 41 { | |
| 42 while (!NILP (plist) && !EQ (Fcar (plist), prop)) | |
| 43 { | |
| 44 /* Check for QUIT, so a circular plist doesn't lock up the | |
| 45 editor. */ | |
| 46 QUIT; | |
| 47 plist = Fcdr (Fcdr (plist)); | |
| 48 } | |
| 49 return plist; | |
| 50 } | |
| 51 | |
| 52 DEFUN ("widget-put", Fwidget_put, 3, 3, 0, /* | |
| 53 In WIDGET set PROPERTY to VALUE. | |
| 54 The value can later be retrieved with `widget-get'. | |
| 55 */ | |
| 56 (widget, property, value)) | |
| 57 { | |
| 58 CHECK_CONS (widget); | |
| 59 XCDR (widget) = Fplist_put (XCDR (widget), property, value); | |
| 60 return widget; | |
| 61 } | |
| 62 | |
| 63 DEFUN ("widget-get", Fwidget_get, 2, 2, 0, /* | |
| 64 In WIDGET, get the value of PROPERTY. | |
| 65 The value could either be specified when the widget was created, or | |
| 66 later with `widget-put'. | |
| 67 */ | |
| 68 (widget, property)) | |
| 69 { | |
| 70 Lisp_Object value = Qnil; | |
| 71 | |
| 72 while (1) | |
| 73 { | |
| 74 Lisp_Object tmp = Fwidget_plist_member (Fcdr (widget), property); | |
| 75 if (!NILP (tmp)) | |
| 76 { | |
| 77 value = Fcar (Fcdr (tmp)); | |
| 78 break; | |
| 79 } | |
| 80 tmp = Fcar (widget); | |
| 81 if (!NILP (tmp)) | |
| 82 { | |
| 83 widget = Fget (tmp, Qwidget_type, Qnil); | |
| 84 continue; | |
| 85 } | |
| 86 break; | |
| 87 } | |
| 88 return value; | |
| 89 } | |
| 90 | |
| 91 DEFUN ("widget-apply", Fwidget_apply, 2, MANY, 0, /* | |
| 92 Apply the value of WIDGET's PROPERTY to the widget itself. | |
| 93 ARGS are passed as extra arguments to the function. | |
|
4693
80cd90837ac5
Add argument information to remaining MANY or UNEVALLED C subrs.
Aidan Kehoe <kehoea@parhasard.net>
parents:
563
diff
changeset
|
94 |
|
80cd90837ac5
Add argument information to remaining MANY or UNEVALLED C subrs.
Aidan Kehoe <kehoea@parhasard.net>
parents:
563
diff
changeset
|
95 arguments: (WIDGET PROPERTY &rest ARGS) |
| 428 | 96 */ |
| 97 (int nargs, Lisp_Object *args)) | |
| 98 { | |
| 99 /* This function can GC */ | |
| 100 Lisp_Object newargs[3]; | |
| 101 struct gcpro gcpro1; | |
| 102 | |
| 103 newargs[0] = Fwidget_get (args[0], args[1]); | |
| 104 newargs[1] = args[0]; | |
| 105 newargs[2] = Flist (nargs - 2, args + 2); | |
| 434 | 106 GCPRO1 (newargs[2]); |
| 428 | 107 RETURN_UNGCPRO (Fapply (3, newargs)); |
| 108 } | |
| 109 | |
| 110 void | |
| 111 syms_of_widget (void) | |
| 112 { | |
| 563 | 113 DEFSYMBOL (Qwidget_type); |
| 428 | 114 |
| 115 DEFSUBR (Fwidget_plist_member); | |
| 116 DEFSUBR (Fwidget_put); | |
| 117 DEFSUBR (Fwidget_get); | |
| 118 DEFSUBR (Fwidget_apply); | |
| 119 } |