Mercurial > hg > xemacs-beta
annotate netinstall/other.cc @ 4783:e29fcfd8df5f
Eliminate most core code byte-compile warnings.
2009-12-18 Aidan Kehoe <kehoea@parhasard.net>
* alist.el (modify-alist):
* autoload.el (update-autoload-files, autoload-print-form):
* bytecomp.el (batch-byte-compile-1)
(byte-compile-multiple-value-call, byte-compile-funcall)
(byte-compile-insert, byte-compile-concat, byte-compile-list)
(byte-compile-normal-call, byte-compile-flush-pending):
* cl-macs.el (letf):
* cl.el:
* disass.el (disassemble-1):
* easy-mmode.el (easy-mmode-define-syntax):
* faces.el (set-face-parent):
* files.el (cd):
* finder.el (finder-list-matches, finder-list-keywords)
(finder-compile-keywords):
* frame.el (frame-notice-user-settings)
(frame-remove-geometry-props):
* ldap.el (ldap-delete-entries, ldap-modify-entries)
(ldap-add-entries):
* loadhist.el (unload-feature):
* map-ynp.el (map-y-or-n-p):
* menubar-items.el (default-menubar):
* mouse.el (default-mouse-track-next-move-rect)
(default-mouse-track-next-move-rect)
(default-mouse-track-cleanup-hook)
(default-mouse-track-cleanup-extent):
* mule/ethio-util.el (ethio-fidel-to-sera-buffer)
(ethio-modify-vowel):
* obsolete.el:
* package-get.el (package-get-update-all):
* package-ui.el (pui-list-packages)
(pui-install-selected-packages, pui-install-selected-packages):
* select.el (select-make-extent-for-selection)
(dehilight-selection):
* simple.el (clone-buffer):
* term/tvi970.el:
* term/wyse50.el:
* unicode.el:
(load-unicode-tables):
* x-font-menu.el (fc-make-font-menu-entry)
(x-reset-device-font-menus-xft):
* x-misc.el (x-init-specifier-from-resources):
Eliminate byte-compile warnings, with the exception of Stephen's
various non-defined fontconfig functions, as I don't know if he
plans to add them and is keeping the warnings around as a
reminder. The warnings actually eliminated involve i) using mapcar
instead of mapc where the result is discarded and ii) using a
lambda quoted as data in a context where it is unequivocally used
as a function.
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Fri, 18 Dec 2009 17:49:43 +0000 |
| parents | 3078fd1074e8 |
| children |
| rev | line source |
|---|---|
| 448 | 1 /* |
| 2 * Copyright (c) 2000, Red Hat, Inc. | |
| 3 * | |
| 4 * This program is free software; you can redistribute it and/or modify | |
| 5 * it under the terms of the GNU General Public License as published by | |
| 6 * the Free Software Foundation; either version 2 of the License, or | |
| 7 * (at your option) any later version. | |
| 8 * | |
| 9 * A copy of the GNU General Public License can be found at | |
| 10 * http://www.gnu.org/ | |
| 11 * | |
| 12 * Written by DJ Delorie <dj@cygnus.com> | |
| 13 * | |
| 14 */ | |
| 15 | |
| 16 /* This handles the "other URL" option from the mirror site | |
| 17 selection. */ | |
| 18 | |
| 19 #include "win32.h" | |
| 20 #include <shlobj.h> | |
| 21 #include <stdio.h> | |
| 22 #include <stdlib.h> | |
| 23 #include "dialog.h" | |
| 24 #include "resource.h" | |
| 25 #include "state.h" | |
| 26 #include "msg.h" | |
| 27 #include "log.h" | |
| 28 | |
| 29 /* private shared function, from site.cc */ | |
| 30 void save_site_url (void); | |
| 31 | |
| 32 static void | |
| 33 check_if_enable_next (HWND h) | |
| 34 { | |
| 35 EnableWindow (GetDlgItem (h, IDOK), other_url ? 1 : 0); | |
| 36 } | |
| 37 | |
| 38 static void | |
| 39 load_dialog (HWND h) | |
| 40 { | |
| 41 eset (h, IDC_OTHER_URL, other_url); | |
| 42 check_if_enable_next (h); | |
| 43 } | |
| 44 | |
| 45 static void | |
| 46 save_dialog (HWND h) | |
| 47 { | |
| 48 other_url = eget (h, IDC_OTHER_URL, other_url); | |
| 49 } | |
| 50 | |
| 51 static BOOL | |
| 52 dialog_cmd (HWND h, int id, HWND hwndctl, UINT code) | |
| 53 { | |
| 54 switch (id) | |
| 55 { | |
| 56 | |
| 57 case IDC_OTHER_URL: | |
| 58 save_dialog (h); | |
| 59 check_if_enable_next (h); | |
| 60 break; | |
| 61 | |
| 62 case IDOK: | |
| 63 save_dialog (h); | |
| 64 save_site_url (); | |
| 65 NEXT (IDD_S_LOAD_INI); | |
| 66 break; | |
| 67 | |
| 68 case IDC_BACK: | |
| 69 save_dialog (h); | |
| 70 NEXT (IDD_SITE); | |
| 71 break; | |
| 72 | |
| 73 case IDCANCEL: | |
| 74 NEXT (0); | |
| 75 break; | |
| 76 } | |
| 77 return FALSE; | |
| 78 } | |
| 79 | |
| 80 static BOOL CALLBACK | |
| 81 dialog_proc (HWND h, UINT message, WPARAM wParam, LPARAM lParam) | |
| 82 { | |
| 83 switch (message) | |
| 84 { | |
| 85 case WM_INITDIALOG: | |
| 86 load_dialog (h); | |
| 87 return FALSE; | |
| 88 case WM_COMMAND: | |
| 89 return HANDLE_WM_COMMAND (h, wParam, lParam, dialog_cmd); | |
| 90 } | |
| 91 return FALSE; | |
| 92 } | |
| 93 | |
| 94 void | |
| 95 do_other (HINSTANCE h) | |
| 96 { | |
| 97 int rv = 0; | |
| 98 rv = DialogBox (h, MAKEINTRESOURCE (IDD_OTHER_URL), 0, dialog_proc); | |
| 99 if (rv == -1) | |
| 100 fatal (IDS_DIALOG_FAILED); | |
| 101 | |
| 102 log (0, "site: %s", other_url); | |
| 103 } | |
| 104 |