Mercurial > hg > xemacs-beta
annotate netinstall/dialog.cc @ 5043:d0c14ea98592
various frame-geometry fixes
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-02-15 Ben Wing <ben@xemacs.org>
* EmacsFrame.c:
* EmacsFrame.c (EmacsFrameResize):
* console-msw-impl.h:
* console-msw-impl.h (struct mswindows_frame):
* console-msw-impl.h (FRAME_MSWINDOWS_TARGET_RECT):
* device-tty.c:
* device-tty.c (tty_asynch_device_change):
* event-msw.c:
* event-msw.c (mswindows_wnd_proc):
* faces.c (Fface_list):
* faces.h:
* frame-gtk.c:
* frame-gtk.c (gtk_set_initial_frame_size):
* frame-gtk.c (gtk_set_frame_size):
* frame-msw.c:
* frame-msw.c (mswindows_init_frame_1):
* frame-msw.c (mswindows_set_frame_size):
* frame-msw.c (mswindows_size_frame_internal):
* frame-msw.c (msprinter_init_frame_3):
* frame.c:
* frame.c (enum):
* frame.c (Fmake_frame):
* frame.c (adjust_frame_size):
* frame.c (store_minibuf_frame_prop):
* frame.c (Fframe_property):
* frame.c (Fframe_properties):
* frame.c (Fframe_displayable_pixel_height):
* frame.c (Fframe_displayable_pixel_width):
* frame.c (internal_set_frame_size):
* frame.c (Fset_frame_height):
* frame.c (Fset_frame_pixel_height):
* frame.c (Fset_frame_displayable_pixel_height):
* frame.c (Fset_frame_width):
* frame.c (Fset_frame_pixel_width):
* frame.c (Fset_frame_displayable_pixel_width):
* frame.c (Fset_frame_size):
* frame.c (Fset_frame_pixel_size):
* frame.c (Fset_frame_displayable_pixel_size):
* frame.c (frame_conversion_internal_1):
* frame.c (get_frame_displayable_pixel_size):
* frame.c (change_frame_size_1):
* frame.c (change_frame_size):
* frame.c (generate_title_string):
* frame.h:
* gtk-xemacs.c:
* gtk-xemacs.c (gtk_xemacs_size_request):
* gtk-xemacs.c (gtk_xemacs_size_allocate):
* gtk-xemacs.c (gtk_xemacs_paint):
* gutter.c:
* gutter.c (update_gutter_geometry):
* redisplay.c (end_hold_frame_size_changes):
* redisplay.c (redisplay_frame):
* toolbar.c:
* toolbar.c (update_frame_toolbars_geometry):
* window.c:
* window.c (frame_pixsize_valid_p):
* window.c (check_frame_size):
Various fixes to frame geometry to make it a bit easier to understand
and fix some bugs.
1. IMPORTANT: Some renamings. Will need to be applied carefully to
the carbon repository, in the following order:
-- pixel_to_char_size -> pixel_to_frame_unit_size
-- char_to_pixel_size -> frame_unit_to_pixel_size
-- pixel_to_real_char_size -> pixel_to_char_size
-- char_to_real_pixel_size -> char_to_pixel_size
-- Reverse second and third arguments of change_frame_size() and
change_frame_size_1() to try to make functions consistent in
putting width before height.
-- Eliminate old round_size_to_char, because it didn't really
do anything differently from round_size_to_real_char()
-- round_size_to_real_char -> round_size_to_char; any places that
called the old round_size_to_char should just call the new one.
2. IMPORTANT FOR CARBON: The set_frame_size() method is now passed
sizes in "frame units", like all other frame-sizing functions,
rather than some hacked-up combination of char-cell units and
total pixel size. This only affects window systems that use
"pixelated geometry", and I'm not sure if Carbon is one of them.
MS Windows is pixelated, X and GTK are not. For pixelated-geometry
systems, the size in set_frame_size() is in displayable pixels
rather than total pixels and needs to be converted appropriately;
take a look at the changes made to mswindows_set_frame_size()
method if necessary.
3. Add a big long comment in frame.c describing how frame geometry
works.
4. Remove MS Windows-specific character height and width fields,
duplicative and unused.
5. frame-displayable-pixel-* and set-frame-displayable-pixel-*
didn't use to work on MS Windows, but they do now.
6. In general, clean up the handling of "pixelated geometry" so
that fewer functions have to worry about this. This is really
an abomination that should be removed entirely but that will
have to happen later. Fix some buggy code in
frame_conversion_internal() that happened to "work" because it
was countered by oppositely buggy code in change_frame_size().
7. Clean up some frame-size code in toolbar.c and use functions
already provided in frame.c instead of rolling its own.
8. Fix check_frame_size() in window.c, which formerly didn't take
pixelated geometry into account.
| author | Ben Wing <ben@xemacs.org> |
|---|---|
| date | Mon, 15 Feb 2010 22:14:11 -0600 |
| parents | 3078fd1074e8 |
| children |
| rev | line source |
|---|---|
| 448 | 1 /* |
| 2 * Copyright (c) 2000, Red Hat, Inc. | |
| 3 * | |
| 4 * This program is free software; you can redistribute it and/or modify | |
| 5 * it under the terms of the GNU General Public License as published by | |
| 6 * the Free Software Foundation; either version 2 of the License, or | |
| 7 * (at your option) any later version. | |
| 8 * | |
| 9 * A copy of the GNU General Public License can be found at | |
| 10 * http://www.gnu.org/ | |
| 11 * | |
| 12 * Written by DJ Delorie <dj@cygnus.com> | |
| 13 * | |
| 14 */ | |
| 15 | |
| 16 /* The purpose of this file is to provide common functionality for | |
| 17 all the dialogs in the program. */ | |
| 18 | |
| 19 #include "win32.h" | |
| 20 #include <stdio.h> | |
| 21 #include <stdlib.h> | |
| 22 #include "dialog.h" | |
| 23 #include "msg.h" | |
| 24 #include "log.h" | |
| 25 | |
| 26 char * | |
| 27 eget (HWND h, int id, char *var) | |
| 28 { | |
| 29 char tmp[4000]; | |
| 30 if (var) | |
| 31 { | |
| 32 free (var); | |
| 33 var = 0; | |
| 34 } | |
| 35 if (GetDlgItemText (h, id, tmp, sizeof (tmp)) > 0) | |
| 36 { | |
| 37 var = (char *) malloc (strlen (tmp)+1); | |
| 38 strcpy (var, tmp); | |
| 39 } | |
| 40 return var; | |
| 41 } | |
| 42 | |
| 43 int | |
| 44 eget (HWND h, int id) | |
| 45 { | |
| 46 BOOL s; | |
| 47 int r = GetDlgItemInt (h, id, &s, TRUE); | |
| 48 return r; | |
| 49 } | |
| 50 | |
| 51 void | |
| 52 eset (HWND h, int id, char *val) | |
| 53 { | |
| 54 SetDlgItemText (h, id, val); | |
| 55 } | |
| 56 | |
| 57 void | |
| 58 eset (HWND h, int id, int val) | |
| 59 { | |
| 60 SetDlgItemInt (h, id, (UINT)val, TRUE); | |
| 61 } | |
| 62 | |
| 63 int | |
| 64 rbget (HWND h, int *ids) | |
| 65 { | |
| 66 int i; | |
| 67 for (i=0; ids[i]; i++) | |
| 68 if (IsDlgButtonChecked (h, ids[i]) == BST_CHECKED) | |
| 69 return ids[i]; | |
| 70 return 0; | |
| 71 } | |
| 72 | |
| 73 void | |
| 74 rbset (HWND h, int *ids, int id) | |
| 75 { | |
| 76 int i; | |
| 77 for (i=0; ids[i]; i++) | |
| 78 CheckDlgButton (h, ids[i], id==ids[i] ? BST_CHECKED : BST_UNCHECKED); | |
| 79 } | |
| 80 | |
| 81 void | |
| 82 fatal (char *m) | |
| 83 { | |
| 84 DWORD e = GetLastError (); | |
| 85 char *buf; | |
| 86 FormatMessage (FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, | |
| 87 0, | |
| 88 e, | |
| 89 0, | |
| 90 (CHAR *)&buf, | |
| 91 0, | |
| 92 0); | |
| 93 MessageBox (0, buf, m, 0); | |
| 94 exit_setup (1); | |
| 95 } |