Mercurial > hg > xemacs-beta
annotate src/README.global-renaming @ 5882:bbe4146603db
Reduce regexp usage, now CL-oriented non-regexp code available, core Lisp
lisp/ChangeLog addition:
2015-04-01 Aidan Kehoe <kehoea@parhasard.net>
When calling #'string-match with a REGEXP without regular
expression special characters, call #'search, #'mismatch, #'find,
etc. instead, making our code less likely to side-effect other
functions' match data and a little faster.
* apropos.el (apropos-command):
* apropos.el (apropos):
Call (position ?\n ...) rather than (string-match "\n" ...) here.
* buff-menu.el:
* buff-menu.el (buffers-menu-omit-invisible-buffers):
Don't fire up the regexp engine just to check if a string starts
with a space.
* buff-menu.el (select-buffers-tab-buffers-by-mode):
Don't fire up the regexp engine just to compare mode basenames.
* buff-menu.el (format-buffers-tab-line):
* buff-menu.el (build-buffers-tab-internal): Moved to being a
label within the following.
* buff-menu.el (buffers-tab-items): Use the label.
* bytecomp.el (byte-compile-log-1):
Don't fire up the regexp engine just to look for a newline.
* cus-edit.el (get):
Ditto.
* cus-edit.el (custom-variable-value-create):
Ditto, but for a colon.
* descr-text.el (describe-text-sexp):
Ditto.
* descr-text.el (describe-char-unicode-data):
Use #'split-string-by-char given that we're just looking for a
semicolon.
* descr-text.el (describe-char):
Don't fire up the regexp engine just to look for a newline.
* disass.el (disassemble-internal):
Ditto.
* files.el (file-name-sans-extension):
Implement this using #'position.
* files.el (file-name-extension):
Correct this function's docstring, implement it in terms of
#'position.
* files.el (insert-directory):
Don't fire up the regexp engine to split a string by space; don't
reverse the list of switches, this is actually a longstand bug as
far as I can see.
* gnuserv.el (gnuserv-process-filter):
Use #'position here, instead of consing inside #'split-string
needlessly.
* gtk-file-dialog.el (gtk-file-dialog-update-dropdown):
Use #'split-string-by-char here, don't fire up #'split-string for
directory-sep-char.
* gtk-font-menu.el (hack-font-truename):
Implement this more cheaply in terms of #'find,
#'split-string-by-char, #'equal, rather than #'string-match,
#'split-string, #'string-equal.
* hyper-apropos.el (hyper-apropos-grok-functions):
* hyper-apropos.el (hyper-apropos-grok-variables):
Look for a newline using #'position rather than #'string-match in
these functions.
* info.el (Info-insert-dir):
* info.el (Info-insert-file-contents):
* info.el (Info-follow-reference):
* info.el (Info-extract-menu-node-name):
* info.el (Info-menu):
Look for fixed strings using #'position or #'search as appropriate
in this file.
* ldap.el (ldap-decode-string):
* ldap.el (ldap-encode-string):
#'encode-coding-string, #'decode-coding-string are always
available, don't check if they're fboundp.
* ldap.el (ldap-decode-address):
* ldap.el (ldap-encode-address):
Use #'split-string-by-char in these functions.
* lisp-mnt.el (lm-creation-date):
* lisp-mnt.el (lm-last-modified-date):
Don't fire up the regexp engine just to look for spaces in this file.
* menubar-items.el (default-menubar):
Use (not (mismatch ...)) rather than #'string-match here, for
simple regexp.
Use (search "beta" ...) rather than (string-match "beta" ...)
* menubar-items.el (sort-buffers-menu-alphabetically):
* menubar-items.el (sort-buffers-menu-by-mode-then-alphabetically):
* menubar-items.el (group-buffers-menu-by-mode-then-alphabetically):
Don't fire up the regexp engine to check if a string starts with
a space or an asterisk.
Use the more fine-grained results of #'compare-strings; compare
case-insensitively for the buffer menu.
* menubar-items.el (list-all-buffers):
* menubar-items.el (tutorials-menu-filter):
Use #'equal rather than #'string-equal, which, in this context,
has the drawback of not having a bytecode, and no redeeming
features.
* minibuf.el:
* minibuf.el (un-substitute-in-file-name):
Use #'count, rather than counting the occurences of $ using the
regexp engine.
* minibuf.el (read-file-name-internal-1):
Don't fire up the regexp engine to search for ?=.
* mouse.el (mouse-eval-sexp):
Check for newline with #'find.
* msw-font-menu.el (mswindows-reset-device-font-menus):
Split a string by newline with #'split-string-by-char.
* mule/japanese.el:
* mule/japanese.el ("Japanese"):
Use #'search rather than #'string-match; canoncase before
comparing; fix a bug I had introduced where I had been making case
insensitive comparisons where the case mattered.
* mule/korea-util.el (default-korean-keyboard):
Look for ?3 using #'find, not #'string-march.
* mule/korea-util.el (quail-hangul-switch-hanja):
Search for a fixed string using #'search.
* mule/mule-cmds.el (set-locale-for-language-environment):
#'position, #'substitute rather than #'string-match,
#'replace-in-string.
* newcomment.el (comment-make-extra-lines):
Use #'search rather than #'string-match for a simple string.
* package-get.el (package-get-remote-filename):
Use #'position when looking for ?@
* process.el (setenv):
* process.el (read-envvar-name):
Use #'position when looking for ?=.
* replace.el (map-query-replace-regexp):
Use #'split-string-by-char instead of using an inline
implementation of it.
* select.el (select-convert-from-cf-text):
* select.el (select-convert-from-cf-unicodetext):
Use #'position rather than #'string-match in these functions.
* setup-paths.el (paths-emacs-data-root-p):
Use #'search when looking for simple string.
* sound.el (load-sound-file):
Use #'split-string-by-char rather than an inline reimplementation
of same.
* startup.el (splash-screen-window-body):
* startup.el (splash-screen-tty-body):
Search for simple strings using #'search.
* version.el (emacs-version):
Ditto.
* x-font-menu.el (hack-font-truename):
Implement this more cheaply in terms of #'find,
#'split-string-by-char, #'equal, rather than #'string-match,
#'split-string, #'string-equal.
* x-font-menu.el (x-reset-device-font-menus-core):
Use #'split-string-by-char here.
* x-init.el (x-initialize-keyboard):
Search for a simple string using #'search.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Wed, 01 Apr 2015 14:28:20 +0100 |
parents | 2aa9cd456ae7 |
children |
rev | line source |
---|---|
868 | 1 README.global-renaming |
2 | |
3 This file documents the generic scripts that have been used to implement | |
4 the recent type renamings, e.g. the "great integral type renaming" and the | |
5 "text/char type renaming". More information about these changes can be | |
6 found in the Internals manual. | |
7 | |
8 A sample script to do such renaming is this (used in the great integral | |
9 type renaming): | |
10 | |
11 ----------------------------------- cut ------------------------------------ | |
12 files="*.[ch] s/*.h m/*.h config.h.in ../configure.in Makefile.in.in ../lib-src/*.[ch] ../lwlib/*.[ch]" | |
13 gr Memory_Count Bytecount $files | |
14 gr Lstream_Data_Count Bytecount $files | |
15 gr Element_Count Elemcount $files | |
16 gr Hash_Code Hashcode $files | |
17 gr extcount bytecount $files | |
18 gr bufpos charbpos $files | |
19 gr bytind bytebpos $files | |
20 gr memind membpos $files | |
21 gr bufbyte intbyte $files | |
22 gr Extcount Bytecount $files | |
23 gr Bufpos Charbpos $files | |
24 gr Bytind Bytebpos $files | |
25 gr Memind Membpos $files | |
26 gr Bufbyte Intbyte $files | |
27 gr EXTCOUNT BYTECOUNT $files | |
28 gr BUFPOS CHARBPOS $files | |
29 gr BYTIND BYTEBPOS $files | |
30 gr MEMIND MEMBPOS $files | |
31 gr BUFBYTE INTBYTE $files | |
32 gr MEMORY_COUNT BYTECOUNT $files | |
33 gr LSTREAM_DATA_COUNT BYTECOUNT $files | |
34 gr ELEMENT_COUNT ELEMCOUNT $files | |
35 gr HASH_CODE HASHCODE $files | |
36 ----------------------------------- cut ------------------------------------ | |
37 | |
38 | |
39 `fixtypes.sh' is a Bourne-shell script; it uses 'gr': | |
40 | |
41 | |
42 ----------------------------------- cut ------------------------------------ | |
43 #!/bin/sh | |
44 | |
45 # Usage is like this: | |
46 | |
47 # gr FROM TO FILES ... | |
48 | |
49 # globally replace FROM with TO in FILES. FROM and TO are regular expressions. | |
50 # backup files are stored in the `backup' directory. | |
51 from="$1" | |
52 to="$2" | |
53 shift 2 | |
54 echo ${1+"$@"} | xargs global-replace "s/$from/$to/g" | |
55 ----------------------------------- cut ------------------------------------ | |
56 | |
57 | |
58 `gr' in turn uses a Perl script to do its real work, `global-replace', | |
59 which follows: | |
60 | |
61 | |
62 ----------------------------------- cut ------------------------------------ | |
63 : #-*- Perl -*- | |
64 | |
65 ### global-replace --- modify the contents of a file by a Perl expression | |
66 | |
67 ## Copyright (C) 1999 Martin Buchholz. | |
68 ## Copyright (C) 2001, 2002 Ben Wing. | |
69 | |
70 ## Authors: Martin Buchholz <martin@xemacs.org>, Ben Wing <ben@xemacs.org> | |
71 ## Maintainer: Ben Wing <ben@xemacs.org> | |
72 ## Current Version: 1.2, March 12, 2002 | |
73 | |
5405 | 74 # This program is free software: you can redistribute it and/or modify it |
75 # under the terms of the GNU General Public License as published by the | |
76 # Free Software Foundation, either version 3 of the License, or (at your | |
77 # option) any later version. | |
78 # | |
79 # This program is distributed in the hope that it will be useful, but WITHOUT | |
80 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
81 # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
82 # for more details. | |
83 # | |
868 | 84 # You should have received a copy of the GNU General Public License |
5405 | 85 # along with this program. If not, see <http://www.gnu.org/licenses/>. |
868 | 86 |
87 eval 'exec perl -w -S $0 ${1+"$@"}' | |
88 if 0; | |
89 | |
90 use strict; | |
91 use FileHandle; | |
92 use Carp; | |
93 use Getopt::Long; | |
94 use File::Basename; | |
95 | |
96 (my $myName = $0) =~ s@.*/@@; my $usage=" | |
97 Usage: $myName [--help] [--backup-dir=DIR] [--line-mode] [--hunk-mode] | |
98 PERLEXPR FILE ... | |
99 | |
100 Globally modify a file, either line by line or in one big hunk. | |
101 | |
102 Typical usage is like this: | |
103 | |
104 [with GNU print, GNU xargs: guaranteed to handle spaces, quotes, etc. | |
105 in file names] | |
106 | |
107 find . -name '*.[ch]' -print0 | xargs -0 $0 's/\bCONST\b/const/g'\n | |
108 | |
109 [with non-GNU print, xargs] | |
110 | |
111 find . -name '*.[ch]' -print | xargs $0 's/\bCONST\b/const/g'\n | |
112 | |
113 | |
114 The file is read in, either line by line (with --line-mode specified) | |
115 or in one big hunk (with --hunk-mode specified; it's the default), and | |
116 the Perl expression is then evalled with \$_ set to the line or hunk of | |
117 text, including the terminating newline if there is one. It should | |
118 destructively modify the value there, storing the changed result in \$_. | |
119 | |
120 Files in which any modifications are made are backed up to the directory | |
121 specified using --backup-dir, or to `backup.orig' by default. To disable | |
122 this, use --backup-dir= with no argument. | |
123 | |
124 Hunk mode is the default because it is MUCH MUCH faster than line-by-line. | |
125 Use line-by-line only when it matters, e.g. you want to do a replacement | |
126 only once per line (the default without the `g' argument). Conversely, | |
127 when using hunk mode, *ALWAYS* use `g'; otherwise, you will only make one | |
128 replacement in the entire file! | |
129 "; | |
130 | |
131 my %options = (); | |
132 $Getopt::Long::ignorecase = 0; | |
133 &GetOptions ( | |
134 \%options, | |
135 'help', 'backup-dir=s', 'line-mode', 'hunk-mode', | |
136 ); | |
137 | |
138 | |
139 die $usage if $options{"help"} or @ARGV <= 1; | |
140 my $code = shift; | |
141 | |
142 die $usage if grep (-d || ! -w, @ARGV); | |
143 | |
144 sub SafeOpen { | |
145 open ((my $fh = new FileHandle), $_[0]); | |
146 confess "Can't open $_[0]: $!" if ! defined $fh; | |
147 return $fh; | |
148 } | |
149 | |
150 sub SafeClose { | |
151 close $_[0] or confess "Can't close $_[0]: $!"; | |
152 } | |
153 | |
154 sub FileContents { | |
155 my $fh = SafeOpen ("< $_[0]"); | |
156 my $olddollarslash = $/; | |
157 local $/ = undef; | |
158 my $contents = <$fh>; | |
159 $/ = $olddollarslash; | |
160 return $contents; | |
161 } | |
162 | |
163 sub WriteStringToFile { | |
164 my $fh = SafeOpen ("> $_[0]"); | |
165 binmode $fh; | |
166 print $fh $_[1] or confess "$_[0]: $!\n"; | |
167 SafeClose $fh; | |
168 } | |
169 | |
170 foreach my $file (@ARGV) { | |
171 my $changed_p = 0; | |
172 my $new_contents = ""; | |
173 if ($options{"line-mode"}) { | |
174 my $fh = SafeOpen $file; | |
175 while (<$fh>) { | |
176 my $save_line = $_; | |
177 eval $code; | |
178 $changed_p = 1 if $save_line ne $_; | |
179 $new_contents .= $_; | |
180 } | |
181 } else { | |
182 my $orig_contents = $_ = FileContents $file; | |
183 eval $code; | |
184 if ($_ ne $orig_contents) { | |
185 $changed_p = 1; | |
186 $new_contents = $_; | |
187 } | |
188 } | |
189 | |
190 if ($changed_p) { | |
191 my $backdir = $options{"backup-dir"}; | |
192 $backdir = "backup.orig" if !defined ($backdir); | |
193 if ($backdir) { | |
194 my ($name, $path, $suffix) = fileparse ($file, ""); | |
195 my $backfulldir = $path . $backdir; | |
196 my $backfile = "$backfulldir/$name"; | |
197 mkdir $backfulldir, 0755 unless -d $backfulldir; | |
198 print "modifying $file (original saved in $backfile)\n"; | |
199 rename $file, $backfile; | |
200 } | |
201 WriteStringToFile ($file, $new_contents); | |
202 } | |
203 } | |
204 ----------------------------------- cut ------------------------------------ |