annotate etc/CODING-STANDARDS @ 800:a5954632b187

[xemacs-hg @ 2002-03-31 08:27:14 by ben] more fixes, first crack at finishing behavior implementation TODO.ben-mule-21-5: Update. configure.in: Fix for new error-checking types. make-mswin-unicode.pl: Don't be fucked up by CRLF. Output code to force errors when nonintercepted Windows calls issued. behavior.el, dumped-lisp.el, menubar-items.el: Add support for saving using custom. Load into a dumped XEmacs. Correct :title to :short-doc in accordance with behavior-defs.el. Add a submenu under Options for turning on/off behaviors. cl-macs.el: Properly document `loop'. Fix a minor bug in keymap iteration and add support for bit-vector iteration. lisp-mode.el: Rearrange and add items for macro expanding. menubar-items.el: Document connection between these two functions. window.el: Port stuff from GNU 21.1. config.inc.samp, xemacs.mak: Separate out and add new variable for controlling error-checking. s/windowsnt.h: Use new ERROR_CHECK_ALL; not related to DEBUG_XEMACS. alloc.c, backtrace.h, buffer.c, buffer.h, bytecode.c, callproc.c, casetab.c, charset.h, chartab.c, cmdloop.c, config.h.in, console-msw.c, console-stream.c, console-tty.c, console.c, console.h, data.c, device-msw.c, device.c, device.h, dired-msw.c, dired.c, dumper.c, editfns.c, eldap.c, elhash.c, emacs.c, eval.c, event-Xt.c, event-gtk.c, event-msw.c, event-stream.c, events.c, extents.c, faces.c, file-coding.c, file-coding.h, fileio.c, frame-msw.c, frame.c, frame.h, glyphs-gtk.c, glyphs-msw.c, glyphs-shared.c, glyphs-widget.c, glyphs-x.c, glyphs.c, glyphs.h, insdel.c, intl-auto-encap-win32.c, intl-auto-encap-win32.h, intl-encap-win32.c, intl-win32.c, keymap.c, lisp-union.h, lisp.h, lread.c, lrecord.h, lstream.c, lstream.h, macros.c, marker.c, md5.c, menubar-x.c, menubar.c, mule-coding.c, ntproc.c, objects-gtk.c, objects-msw.c, objects-x.c, objects.c, opaque.c, print.c, process-nt.c, process-unix.c, process.c, rangetab.c, redisplay-msw.c, redisplay-output.c, redisplay.c, regex.c, scrollbar-msw.c, select-msw.c, signal.c, specifier.c, specifier.h, symbols.c, sysdep.c, syswindows.h, text.c, text.h, toolbar-msw.c, tooltalk.c, ui-gtk.c, unicode.c, window.c: Redo error-checking macros: ERROR_CHECK_TYPECHECK -> ERROR_CHECK_TYPES, ERROR_CHECK_CHARBPOS -> ERROR_CHECK_TEXT, add ERROR_CHECK_DISPLAY, ERROR_CHECK_STRUCTURES. Document these in config.h.in. Fix code to follow docs. Fix *_checking_assert() in accordance with new names. Attempt to fix periodic redisplay crash freeing display line structures. Add first implementation of sledgehammer redisplay check. Redo print_*() to use write_fmt_string(), write_fmt_string_lisp(). Fix bug in md5 handling. Rename character-to-unicode to char-to-unicode; same for unicode-to-char{acter}. Move chartab documentation to `make-char-table'. Some header cleanup. Clean up remaining places where nonintercepted Windows calls are being used. automated/mule-tests.el: Fix for new Unicode support.
author ben
date Sun, 31 Mar 2002 08:30:17 +0000
parents 376386a54a3c
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
1 XEMACS CODING STANDARDS
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
2
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
3 by
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
4
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
5 Ben Wing
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
6
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
7
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
8 Copyright (c) 1996 Ben Wing.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
9
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
10
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
11 This file documents the coding standards used in the XEmacs source
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
12 code. Note that XEmacs follows the GNU coding standards, which are
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
13 documented separately in ../man/standards.texi. This file only
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
14 documents standards that are not included in that document; typically
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
15 this consists of standards that are specifically relevant to the
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
16 XEmacs code itself.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
17
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
18 First, a recap of the GNU standards:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
19
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
20 -- Put a space after every comma.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
21 -- Put a space before the parenthesis that begins a function call,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
22 macro call, function declaration or definition, or control
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
23 statement (if, while, switch, for). (DO NOT do this for macro
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
24 definitions; this is invalid preprocessor syntax.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
25 -- The brace that begins a control statement (if, while, for, switch,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
26 do) or a function definition should go on a line by itself.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
27 -- In function definitions, put the return type and all other
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
28 qualifiers on a line before the function name. Thus, the function
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
29 name is always at the beginning of a line.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
30 -- Indentation level is two spaces. (However, the first and following
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
31 statements of a while/for/if/etc. block are indented four spaces
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
32 from the while/for/if keyword. The opening and closing braces are
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
33 indented two spaces.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
34 -- Variable and function names should be all lowercase, with underscores
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
35 separating words, except for a prefixing tag, which may be in
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
36 uppercase. Do not use the mixed-case convention (e.g.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
37 SetVariableToValue ()) and *especially* do not use Microsoft
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
38 Hungarian notation (char **rgszRedundantTag).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
39 -- preprocessor and enum constants should be all uppercase, and should
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
40 be prefixed with a tag that groups related constants together.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
41
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
42
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
43 Now, the XEmacs coding standards:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
44
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
45 **** Specially-prefixed functions/variables:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
46
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
47 -- All global C variables whose value is constant and is a symbol begin
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
48 with a capital Q, e.g. Qkey_press_event. (The type will always be
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
49 Lisp_Object.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
50 -- All other global C variables whose value is a Lisp_Object (this
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
51 includes variables that forward into Lisp variables plus others like
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
52 Vselected_console) begin with a capital V.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
53 -- No C variables whose value is other than a Lisp_Object should begin
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
54 with a capital V. (This includes C variables that forward into
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
55 integer or boolean Lisp variables.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
56 -- All global C variables whose value is a struct Lisp_Subr begin with a
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
57 capital S. (This only occurs in connection with DEFUN ()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
58 -- All C functions that are Lisp primitives begin with a capital F,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
59 and no others should begin this way.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
60
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
61 **** Functions for manipulating Lisp types:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
62
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
63 -- Any function that creates an empty or mostly empty Lisp object
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
64 should begin allocate_(). (*Not* make_().) (Except, of course,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
65 for Lisp primitives, which usually begin Fmake_()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
66 -- Any function that converts a pointer into an equivalent Lisp_Object
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
67 should begin make_().
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
68 -- Any function that converts a Lisp_Object into its equivalent pointer
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
69 and checks the type and validity of the object (e.g. making sure
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
70 it's not dead) should begin decode_().
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
71 -- Any function that looks up a Lisp object (e.g. buffer, face) given
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
72 a symbol or string should begin get_(). (Except, of course, for
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
73 Lisp primitives, which usually begin Fget_()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
74
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
75 **** Other:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
76
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
77 -- Any header-file declarations of the sort
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
78
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
79 struct foobar;
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
80
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
81 go into the "types" section of lisp.h.