Mercurial > hg > xemacs-beta
annotate netinstall/localdir.cc @ 5169:6c6d78781d59
cleanup of code related to xfree(), better KKCC backtrace capabilities, document XD_INLINE_LISP_OBJECT_BLOCK_PTR, fix some memory leaks, other code cleanup
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-03-24 Ben Wing <ben@xemacs.org>
* array.h:
* array.h (XD_LISP_DYNARR_DESC):
* dumper.c (pdump_register_sub):
* dumper.c (pdump_store_new_pointer_offsets):
* dumper.c (pdump_reloc_one_mc):
* elhash.c:
* gc.c (lispdesc_one_description_line_size):
* gc.c (kkcc_marking):
* lrecord.h:
* lrecord.h (IF_NEW_GC):
* lrecord.h (enum memory_description_type):
* lrecord.h (enum data_description_entry_flags):
* lrecord.h (struct opaque_convert_functions):
Rename XD_LISP_OBJECT_BLOCK_PTR to XD_INLINE_LISP_OBJECT_BLOCK_PTR
and document it in lrecord.h.
* data.c:
* data.c (finish_marking_weak_lists):
* data.c (continue_marking_ephemerons):
* data.c (finish_marking_ephemerons):
* elhash.c (MARK_OBJ):
* gc.c:
* gc.c (lispdesc_indirect_count_1):
* gc.c (struct):
* gc.c (kkcc_bt_push):
* gc.c (kkcc_gc_stack_push):
* gc.c (kkcc_gc_stack_push_lisp_object):
* gc.c (kkcc_gc_stack_repush_dirty_object):
* gc.c (KKCC_DO_CHECK_FREE):
* gc.c (mark_object_maybe_checking_free):
* gc.c (mark_struct_contents):
* gc.c (mark_lisp_object_block_contents):
* gc.c (register_for_finalization):
* gc.c (mark_object):
* gc.h:
* lisp.h:
* profile.c:
* profile.c (mark_profiling_info_maphash):
Clean up KKCC code related to DEBUG_XEMACS. Rename
kkcc_backtrace() to kkcc_backtrace_1() and add two params: a
`size' arg to control how many stack elements to print and a
`detailed' arg to control whether Lisp objects are printed using
`debug_print()'. Create front-ends to kkcc_backtrace_1() --
kkcc_detailed_backtrace(), kkcc_short_backtrace(),
kkcc_detailed_backtrace_full(), kkcc_short_backtrace_full(), as
well as shortened versions kbt(), kbts(), kbtf(), kbtsf() -- to
call it with various parameter values. Add an `is_lisp' field to
the stack and backtrace structures and use it to keep track of
whether an object pushed onto the stack is a Lisp object or a
non-Lisp structure; in kkcc_backtrace_1(), don't try to print a
non-Lisp structure as a Lisp object.
* elhash.c:
* extents.c:
* file-coding.c:
* lrecord.h:
* lrecord.h (IF_NEW_GC):
* marker.c:
* marker.c (Fmarker_buffer):
* mule-coding.c:
* number.c:
* rangetab.c:
* specifier.c:
New macros IF_OLD_GC(), IF_NEW_GC() to simplify declaration of
Lisp objects when a finalizer may exist in one but not the other.
Use them appropriately.
* extents.c (finalize_extent_info):
Don't zero out data->soe and data->extents before trying to free,
else we get memory leaks.
* lrecord.h (enum lrecord_type):
Make the first lrecord type have value 1 not 0 so that 0 remains
without implementation and attempts to interpret zeroed memory
as a Lisp object will be more obvious.
* array.c (Dynarr_free):
* device-msw.c (msprinter_delete_device):
* device-tty.c (free_tty_device_struct):
* device-tty.c (tty_delete_device):
* dialog-msw.c (handle_directory_dialog_box):
* dialog-x.c:
* emacs.c (free_argc_argv):
* emodules.c (attempt_module_delete):
* file-coding.c (chain_finalize_coding_stream_1):
* file-coding.c (chain_finalize_coding_stream):
* glyphs-eimage.c:
* glyphs-eimage.c (jpeg_instantiate_unwind):
* glyphs-eimage.c (gif_instantiate_unwind):
* glyphs-eimage.c (png_instantiate_unwind):
* glyphs-eimage.c (tiff_instantiate_unwind):
* imgproc.c:
* imgproc.c (build_EImage_quantable):
* insdel.c (uninit_buffer_text):
* mule-coding.c (iso2022_finalize_detection_state):
* objects-tty.c (tty_finalize_color_instance):
* objects-tty.c (tty_finalize_font_instance):
* objects-tty.c (tty_font_list):
* process.c:
* process.c (finalize_process):
* redisplay.c (add_propagation_runes):
* scrollbar-gtk.c:
* scrollbar-gtk.c (gtk_free_scrollbar_instance):
* scrollbar-gtk.c (gtk_release_scrollbar_instance):
* scrollbar-msw.c:
* scrollbar-msw.c (mswindows_free_scrollbar_instance):
* scrollbar-msw.c (unshow_that_mofo):
* scrollbar-x.c (x_free_scrollbar_instance):
* scrollbar-x.c (x_release_scrollbar_instance):
* select-x.c:
* select-x.c (x_handle_selection_request):
* syntax.c:
* syntax.c (uninit_buffer_syntax_cache):
* text.h (eifree):
If possible, whenever we call xfree() on a field in a structure,
set the field to 0 afterwards. A lot of code is written so that
it checks the value being freed to see if it is non-zero before
freeing it -- doing this and setting the value to 0 afterwards
ensures (a) we won't try to free twice if the cleanup code is
called twice; (b) if the object itself stays around, KKCC won't
crash when attempting to mark the freed field.
* rangetab.c:
Add a finalization method when not NEW_GC to avoid memory leaks.
(#### We still get memory leaks when NEW_GC; need to convert gap
array to Lisp object).
| author | Ben Wing <ben@xemacs.org> |
|---|---|
| date | Wed, 24 Mar 2010 01:22:51 -0500 |
| parents | 685b588e92d8 |
| children |
| rev | line source |
|---|---|
| 448 | 1 /* |
| 2 * Copyright (c) 2000, Red Hat, Inc. | |
| 3 * | |
| 4 * This program is free software; you can redistribute it and/or modify | |
| 5 * it under the terms of the GNU General Public License as published by | |
| 6 * the Free Software Foundation; either version 2 of the License, or | |
| 7 * (at your option) any later version. | |
| 8 * | |
| 9 * A copy of the GNU General Public License can be found at | |
| 10 * http://www.gnu.org/ | |
| 11 * | |
| 12 * Written by Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru> | |
| 13 * based on work and suggestions of DJ Delorie | |
| 14 * | |
| 673 | 15 * Sync'ed with cinstall 2001-10-16 |
| 448 | 16 */ |
| 17 | |
| 18 /* The purpose of this file is to ask the user where they want the | |
| 19 root of the installation to be, and to ask whether the user prefers | |
| 20 text or binary mounts. */ | |
| 21 | |
| 22 #include "win32.h" | |
| 23 #include <shlobj.h> | |
| 24 #include <stdio.h> | |
| 25 #include <stdlib.h> | |
| 26 #include <ctype.h> | |
| 673 | 27 #include <io.h> |
| 448 | 28 |
| 673 | 29 #include "mkdir.h" |
| 448 | 30 #include "dialog.h" |
| 31 #include "resource.h" | |
| 32 #include "state.h" | |
| 33 #include "msg.h" | |
| 34 #include "concat.h" | |
| 35 #include "log.h" | |
| 36 | |
| 37 static void | |
| 38 check_if_enable_next (HWND h) | |
| 39 { | |
| 40 EnableWindow (GetDlgItem (h, IDOK), local_dir != 0); | |
| 41 } | |
| 42 | |
| 43 static void | |
| 44 load_dialog (HWND h) | |
| 45 { | |
| 46 eset (h, IDC_LOCAL_DIR, local_dir); | |
| 47 check_if_enable_next (h); | |
| 48 } | |
| 49 | |
| 50 static void | |
| 51 save_dialog (HWND h) | |
| 52 { | |
| 53 local_dir = eget (h, IDC_LOCAL_DIR, local_dir); | |
| 54 } | |
| 55 | |
| 56 | |
| 57 static int CALLBACK | |
| 58 browse_cb (HWND h, UINT m, LPARAM lp, LPARAM data) | |
| 59 { | |
| 60 switch (m) | |
| 61 { | |
| 62 case BFFM_INITIALIZED: | |
| 63 if (local_dir) | |
| 64 SendMessage (h, BFFM_SETSELECTION, TRUE, (LPARAM)local_dir); | |
| 65 break; | |
| 66 } | |
| 67 return 0; | |
| 68 } | |
| 69 | |
| 70 static void | |
| 71 browse (HWND h) | |
| 72 { | |
| 73 BROWSEINFO bi; | |
| 74 CHAR name[MAX_PATH]; | |
| 75 LPITEMIDLIST pidl; | |
| 76 memset (&bi, 0, sizeof (bi)); | |
| 77 bi.hwndOwner = h; | |
| 78 bi.pszDisplayName = name; | |
| 79 bi.lpszTitle = "Select download directory"; | |
| 80 bi.ulFlags = BIF_RETURNONLYFSDIRS; | |
| 81 bi.lpfn = browse_cb; | |
| 82 pidl = SHBrowseForFolder (&bi); | |
| 83 if (pidl) | |
| 84 { | |
| 85 if (SHGetPathFromIDList (pidl, name)) | |
| 86 eset (h, IDC_LOCAL_DIR, name); | |
| 87 } | |
| 88 } | |
| 89 | |
| 90 | |
| 91 static BOOL | |
| 92 dialog_cmd (HWND h, int id, HWND hwndctl, UINT code) | |
| 93 { | |
| 94 switch (id) | |
| 95 { | |
| 96 | |
| 97 case IDC_LOCAL_DIR: | |
| 98 save_dialog (h); | |
| 99 check_if_enable_next (h); | |
| 100 break; | |
| 101 | |
| 102 case IDC_LOCAL_DIR_BROWSE: | |
| 103 browse (h); | |
| 104 break; | |
| 105 | |
| 106 case IDOK: | |
| 107 save_dialog (h); | |
| 673 | 108 if (_access (local_dir, 0) != 0 && yesno (IDS_CREATE_DIR, local_dir) == IDYES) |
| 109 { | |
| 110 log (0, "Created install directory %s\n", local_dir); | |
| 111 mkdir_p (1, local_dir); | |
| 112 } | |
| 448 | 113 if (SetCurrentDirectoryA (local_dir)) |
| 114 { | |
| 115 switch (source) | |
| 116 { | |
| 117 case IDC_SOURCE_DOWNLOAD: | |
| 118 NEXT (IDD_NET); | |
| 119 break; | |
| 120 case IDC_SOURCE_NETINST: | |
| 121 case IDC_SOURCE_CWD: | |
| 122 NEXT (IDD_ROOT); | |
| 123 break; | |
| 124 default: | |
| 125 NEXT (0); | |
| 126 break; | |
| 127 } | |
| 128 } | |
| 129 else | |
| 130 note (IDS_ERR_CHDIR, local_dir); | |
| 131 | |
| 132 break; | |
| 133 | |
| 134 case IDC_BACK: | |
| 135 save_dialog (h); | |
| 136 NEXT (IDD_SOURCE); | |
| 137 break; | |
| 138 | |
| 139 case IDCANCEL: | |
| 140 NEXT (0); | |
| 141 break; | |
| 142 } | |
| 143 } | |
| 144 | |
| 145 static BOOL CALLBACK | |
| 146 dialog_proc (HWND h, UINT message, WPARAM wParam, LPARAM lParam) | |
| 147 { | |
| 148 switch (message) | |
| 149 { | |
| 150 case WM_INITDIALOG: | |
| 151 load_dialog (h); | |
| 152 return FALSE; | |
| 153 case WM_COMMAND: | |
| 154 return HANDLE_WM_COMMAND (h, wParam, lParam, dialog_cmd); | |
| 155 } | |
| 156 return FALSE; | |
| 157 } | |
| 158 | |
| 159 extern char cwd[_MAX_PATH]; | |
| 160 | |
| 161 void | |
| 162 do_local_dir (HINSTANCE h) | |
| 163 { | |
| 164 int rv = 0; | |
| 165 rv = DialogBox (h, MAKEINTRESOURCE (IDD_LOCAL_DIR), 0, dialog_proc); | |
| 166 if (rv == -1) | |
| 167 fatal (IDS_DIALOG_FAILED); | |
| 168 | |
| 169 log (0, "Selected local directory: %s", local_dir); | |
| 170 } | |
| 171 |