Mercurial > hg > xemacs-beta
annotate src/toolbar-gtk.c @ 5566:4654c01af32b
Improve the implementation, documentation of #'labels, #'flet.
lisp/ChangeLog addition:
2011-09-07 Aidan Kehoe <kehoea@parhasard.net>
* bytecomp.el:
* bytecomp.el (for-effect): Move this earlier in the file, it's
referenced in byte-compile-initial-macro-environment.
* bytecomp.el (byte-compile-initial-macro-environment):
In the byte-compile-macro-environment definition for #'labels, put
off the compiling the lambda bodies until the point where the rest
of the form is being compiled, allowing the lambda bodies to
access appropriate values for byte-compile-bound-variables, and
reducing excessive warning about free variables.
Add a byte-compile-macro-environment definition for #'flet. This
modifies byte-compile-function-environment appropriately, and
warns about bindings of functions that have macro definitions in
the current environment, about functions that have byte codes, and
about functions that have byte-compile methods (which may not do
what the user wants at runtime).
* bytecomp.el (byte-compile-funcall):
If FUNCTION is constant, call #'byte-compile-callargs-warn if
that's appropriate, giving warnings about problems with calling
functions bound with #'labels.
* cl-macs.el:
* cl-macs.el (flet):
Mention the main difference from Common Lisp, that the bindings
are dynamic, not lexical. Counsel the use of #'labels, not #'flet,
for this and other reasons. Explain the limited single use case for
#'flet. Cross-reference to bytecomp.el in a comment.
* cl-macs.el (labels):
Go into detail on which functions may be called from
where. Explain how to access the function definition of a label
within FORM. Add a comment cross-referencing to bytecomp.el.
man/ChangeLog addition:
2011-09-07 Aidan Kehoe <kehoea@parhasard.net>
* cl.texi (Function Bindings):
Move #'labels first, describe it in more detail, explaining that
it is to be preferred over #'flet, and explaining why.
Explain that dynamic bindings with #'flet will also not work when
functions are accessed through their bytecodes.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Wed, 07 Sep 2011 16:26:45 +0100 |
parents | 308d34e9f07d |
children |
rev | line source |
---|---|
714 | 1 /* toolbar implementation -- GTK interface. |
462 | 2 Copyright (C) 1995 Board of Trustees, University of Illinois. |
3 Copyright (C) 1995 Sun Microsystems, Inc. | |
4 Copyright (C) 1995, 1996 Ben Wing. | |
5 Copyright (C) 1996 Chuck Thompson. | |
6 | |
7 This file is part of XEmacs. | |
8 | |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
4917
diff
changeset
|
9 XEmacs is free software: you can redistribute it and/or modify it |
462 | 10 under the terms of the GNU General Public License as published by the |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
4917
diff
changeset
|
11 Free Software Foundation, either version 3 of the License, or (at your |
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
4917
diff
changeset
|
12 option) any later version. |
462 | 13 |
14 XEmacs is distributed in the hope that it will be useful, but WITHOUT | |
15 ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
16 FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
17 for more details. | |
18 | |
19 You should have received a copy of the GNU General Public License | |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
4917
diff
changeset
|
20 along with XEmacs. If not, see <http://www.gnu.org/licenses/>. */ |
462 | 21 |
22 /* Synched up with: Not in FSF. */ | |
23 | |
24 #include <config.h> | |
25 #include "lisp.h" | |
872 | 26 |
714 | 27 #include "frame.h" |
872 | 28 |
4917 | 29 #include "toolbar-xlike.h" |
872 | 30 |
31 #include "console-gtk-impl.h" | |
462 | 32 |
4917 | 33 /* We should really create a 'xlike' console type and fill it with |
714 | 34 ** all the shared code. We would then just use |
4917 | 35 ** CONSOLE_INHERITS_METHOD(x,xlike,blah) |
714 | 36 */ |
4917 | 37 #define gtk_output_frame_toolbars xlike_output_frame_toolbars |
38 #define gtk_output_toolbar_button xlike_output_toolbar_button | |
39 #define gtk_redraw_exposed_toolbars xlike_redraw_exposed_toolbars | |
40 #define gtk_redraw_frame_toolbars xlike_redraw_frame_toolbars | |
41 #define gtk_clear_frame_toolbars xlike_clear_frame_toolbars | |
462 | 42 |
43 | |
44 static void | |
2286 | 45 gtk_initialize_frame_toolbars (struct frame *UNUSED (f)) |
462 | 46 { |
47 } | |
48 | |
49 /* This only calls one function but we go ahead and create this in | |
50 case we ever do decide that we need to do more work. */ | |
51 static void | |
2286 | 52 gtk_free_frame_toolbars (struct frame *UNUSED (f)) |
462 | 53 { |
54 } | |
55 | |
56 | |
57 /************************************************************************/ | |
58 /* initialization */ | |
59 /************************************************************************/ | |
60 | |
61 void | |
62 console_type_create_toolbar_gtk (void) | |
63 { | |
64 CONSOLE_HAS_METHOD (gtk, output_frame_toolbars); | |
905 | 65 CONSOLE_HAS_METHOD (gtk, clear_frame_toolbars); |
462 | 66 CONSOLE_HAS_METHOD (gtk, initialize_frame_toolbars); |
67 CONSOLE_HAS_METHOD (gtk, free_frame_toolbars); | |
68 CONSOLE_HAS_METHOD (gtk, output_toolbar_button); | |
69 CONSOLE_HAS_METHOD (gtk, redraw_exposed_toolbars); | |
70 CONSOLE_HAS_METHOD (gtk, redraw_frame_toolbars); | |
71 } |