Mercurial > hg > xemacs-beta
annotate src/dialog.c @ 5566:4654c01af32b
Improve the implementation, documentation of #'labels, #'flet.
lisp/ChangeLog addition:
2011-09-07 Aidan Kehoe <kehoea@parhasard.net>
* bytecomp.el:
* bytecomp.el (for-effect): Move this earlier in the file, it's
referenced in byte-compile-initial-macro-environment.
* bytecomp.el (byte-compile-initial-macro-environment):
In the byte-compile-macro-environment definition for #'labels, put
off the compiling the lambda bodies until the point where the rest
of the form is being compiled, allowing the lambda bodies to
access appropriate values for byte-compile-bound-variables, and
reducing excessive warning about free variables.
Add a byte-compile-macro-environment definition for #'flet. This
modifies byte-compile-function-environment appropriately, and
warns about bindings of functions that have macro definitions in
the current environment, about functions that have byte codes, and
about functions that have byte-compile methods (which may not do
what the user wants at runtime).
* bytecomp.el (byte-compile-funcall):
If FUNCTION is constant, call #'byte-compile-callargs-warn if
that's appropriate, giving warnings about problems with calling
functions bound with #'labels.
* cl-macs.el:
* cl-macs.el (flet):
Mention the main difference from Common Lisp, that the bindings
are dynamic, not lexical. Counsel the use of #'labels, not #'flet,
for this and other reasons. Explain the limited single use case for
#'flet. Cross-reference to bytecomp.el in a comment.
* cl-macs.el (labels):
Go into detail on which functions may be called from
where. Explain how to access the function definition of a label
within FORM. Add a comment cross-referencing to bytecomp.el.
man/ChangeLog addition:
2011-09-07 Aidan Kehoe <kehoea@parhasard.net>
* cl.texi (Function Bindings):
Move #'labels first, describe it in more detail, explaining that
it is to be preferred over #'flet, and explaining why.
Explain that dynamic bindings with #'flet will also not work when
functions are accessed through their bytecodes.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Wed, 07 Sep 2011 16:26:45 +0100 |
parents | 308d34e9f07d |
children |
rev | line source |
---|---|
428 | 1 /* Implements elisp-programmable dialog boxes -- generic. |
2 Copyright (C) 1993, 1994 Free Software Foundation, Inc. | |
3 Copyright (C) 1995 Tinker Systems and INS Engineering Corp. | |
442 | 4 Copyright (C) 2000 Ben Wing. |
428 | 5 |
6 This file is part of XEmacs. | |
7 | |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
872
diff
changeset
|
8 XEmacs is free software: you can redistribute it and/or modify it |
428 | 9 under the terms of the GNU General Public License as published by the |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
872
diff
changeset
|
10 Free Software Foundation, either version 3 of the License, or (at your |
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
872
diff
changeset
|
11 option) any later version. |
428 | 12 |
13 XEmacs is distributed in the hope that it will be useful, but WITHOUT | |
14 ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
15 FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
16 for more details. | |
17 | |
18 You should have received a copy of the GNU General Public License | |
5402
308d34e9f07d
Changed bulk of GPLv2 or later files identified by script
Mats Lidell <matsl@xemacs.org>
parents:
872
diff
changeset
|
19 along with XEmacs. If not, see <http://www.gnu.org/licenses/>. */ |
428 | 20 |
21 /* Synched up with: Not in FSF. */ | |
22 | |
23 #include <config.h> | |
24 #include "lisp.h" | |
442 | 25 |
872 | 26 #include "frame-impl.h" |
428 | 27 |
442 | 28 Lisp_Object Vdelete_dialog_box_hook; |
29 Lisp_Object Qdelete_dialog_box_hook; | |
428 | 30 |
442 | 31 DEFUN ("make-dialog-box-internal", Fmake_dialog_box_internal, 2, 2, 0, /* |
32 Internal helper function for `make-dialog-box'. | |
33 This handles all dialog-box types except `general'. | |
34 TYPE is the same as the first argument to `make-dialog-box', and KEYS | |
35 a list of the remaining arguments. | |
428 | 36 */ |
442 | 37 (type, keys)) |
428 | 38 { |
39 struct frame *f = selected_frame (); | |
40 | |
442 | 41 CHECK_SYMBOL (type); |
428 | 42 |
872 | 43 if (!HAS_FRAMEMETH_P (f, make_dialog_box_internal)) |
563 | 44 signal_error (Qunimplemented, |
872 | 45 "Device does not support dialogs", FRAME_DEVICE (f)); |
428 | 46 |
872 | 47 return FRAMEMETH (f, make_dialog_box_internal, (f, type, keys)); |
428 | 48 } |
49 | |
50 void | |
51 syms_of_dialog (void) | |
52 { | |
442 | 53 DEFSUBR (Fmake_dialog_box_internal); |
54 | |
55 DEFSYMBOL (Qdelete_dialog_box_hook); | |
428 | 56 } |
57 | |
58 void | |
59 vars_of_dialog (void) | |
60 { | |
61 Fprovide (intern ("dialog")); | |
442 | 62 |
63 DEFVAR_LISP ("delete-dialog-box-hook", &Vdelete_dialog_box_hook /* | |
64 Function or functions to call when a dialog box is about to be deleted. | |
65 One arg, the dialog box id. | |
66 */ ); | |
67 Vdelete_dialog_box_hook = Qnil; | |
428 | 68 } |