annotate etc/CODING-STANDARDS @ 1111:184461bc8de4

[xemacs-hg @ 2002-11-18 06:52:23 by ben] warning fixes, etc. * s/cygwin32.h: -fvtable-thunks is obsolete in GCC 3 and generates warnings. * s/mingw32.h: * s/windowsnt.h: Comment fixes. * emodules.h: Fix warnings from redefining symbols. * eval.c: Fix C++ errors -- no automatic casting between function pointers and void *, function declarations inside of functions not allowed. * event-Xt.c (emacs_Xt_enqueue_focus_event): Warning fixes. * fileio.c (Ffile_truename): Warning fixes. Use LOCAL_TO_WIN32_FILE_FORMAT rather than duplicating it. * glyphs-x.c: Fix style. * intl-auto-encap-win32.c: * intl-auto-encap-win32.h: * intl-encap-win32.c: * intl-encap-win32.c (qxeRegConnectRegistry): * syswindows.h (RegConnectRegistry): DdeCreateStringHandle needs to be manual due to new Cygwin bug. * intl-win32.c: wcslen/wcscmp don't seem to exist under G++ 3, Cygwin. * lisp.h: * lisp-union.h: * lisp-disunion.h: * process-unix.c (unix_send_process): Ugh, C needs volatile and C++ must not have volatile. Remove previous volatile hacks, which don't seem to be working any more. * sheap.c (STATIC_HEAP_SLOP): Try to get a working Cygwin build with old unexec. * sheap.c (more_static_core): No NL's in literals allowed. * symbols.c (Fset): Fix C++ errors. * syswindows.h: Fix Cygwin complaints now that some missing structs have been added. aclocal.m4: Disable shared library modules under Cygwin for the moment, since we need some more tricky coding done and I don't have the time right now. configure.in, configure.usage: code-files.el, loadhist.el: Fix warnings. package-get.el: Fix warnings. NOTE: This was already fixed awhile ago, but reverted by Steve Y. Please be careful. postgresql/Makefile.in.in: Removed. Move common stuff into modues/common/Makefile.common. (Also add extraclean target and a couple of other fixes in that file.) postgresql/configure.ac: Extract out common configure stuff into modules/common/configure-{pre,post}.ac. postgresql/postgresql.c: Fix warning. ldap/Makefile.in.in: Removed. Move common stuff into modues/common/Makefile.common. (Also add extraclean target and a couple of other fixes in that file.) ldap/configure.ac: Extract out common configure stuff into modules/common/configure-{pre,post}.ac. common/Makefile.common: Common stuff is here.
author ben
date Mon, 18 Nov 2002 06:53:08 +0000
parents 376386a54a3c
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
1 XEMACS CODING STANDARDS
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
2
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
3 by
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
4
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
5 Ben Wing
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
6
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
7
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
8 Copyright (c) 1996 Ben Wing.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
9
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
10
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
11 This file documents the coding standards used in the XEmacs source
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
12 code. Note that XEmacs follows the GNU coding standards, which are
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
13 documented separately in ../man/standards.texi. This file only
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
14 documents standards that are not included in that document; typically
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
15 this consists of standards that are specifically relevant to the
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
16 XEmacs code itself.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
17
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
18 First, a recap of the GNU standards:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
19
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
20 -- Put a space after every comma.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
21 -- Put a space before the parenthesis that begins a function call,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
22 macro call, function declaration or definition, or control
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
23 statement (if, while, switch, for). (DO NOT do this for macro
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
24 definitions; this is invalid preprocessor syntax.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
25 -- The brace that begins a control statement (if, while, for, switch,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
26 do) or a function definition should go on a line by itself.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
27 -- In function definitions, put the return type and all other
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
28 qualifiers on a line before the function name. Thus, the function
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
29 name is always at the beginning of a line.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
30 -- Indentation level is two spaces. (However, the first and following
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
31 statements of a while/for/if/etc. block are indented four spaces
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
32 from the while/for/if keyword. The opening and closing braces are
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
33 indented two spaces.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
34 -- Variable and function names should be all lowercase, with underscores
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
35 separating words, except for a prefixing tag, which may be in
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
36 uppercase. Do not use the mixed-case convention (e.g.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
37 SetVariableToValue ()) and *especially* do not use Microsoft
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
38 Hungarian notation (char **rgszRedundantTag).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
39 -- preprocessor and enum constants should be all uppercase, and should
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
40 be prefixed with a tag that groups related constants together.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
41
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
42
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
43 Now, the XEmacs coding standards:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
44
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
45 **** Specially-prefixed functions/variables:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
46
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
47 -- All global C variables whose value is constant and is a symbol begin
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
48 with a capital Q, e.g. Qkey_press_event. (The type will always be
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
49 Lisp_Object.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
50 -- All other global C variables whose value is a Lisp_Object (this
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
51 includes variables that forward into Lisp variables plus others like
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
52 Vselected_console) begin with a capital V.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
53 -- No C variables whose value is other than a Lisp_Object should begin
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
54 with a capital V. (This includes C variables that forward into
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
55 integer or boolean Lisp variables.)
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
56 -- All global C variables whose value is a struct Lisp_Subr begin with a
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
57 capital S. (This only occurs in connection with DEFUN ()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
58 -- All C functions that are Lisp primitives begin with a capital F,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
59 and no others should begin this way.
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
60
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
61 **** Functions for manipulating Lisp types:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
62
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
63 -- Any function that creates an empty or mostly empty Lisp object
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
64 should begin allocate_(). (*Not* make_().) (Except, of course,
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
65 for Lisp primitives, which usually begin Fmake_()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
66 -- Any function that converts a pointer into an equivalent Lisp_Object
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
67 should begin make_().
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
68 -- Any function that converts a Lisp_Object into its equivalent pointer
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
69 and checks the type and validity of the object (e.g. making sure
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
70 it's not dead) should begin decode_().
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
71 -- Any function that looks up a Lisp object (e.g. buffer, face) given
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
72 a symbol or string should begin get_(). (Except, of course, for
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
73 Lisp primitives, which usually begin Fget_()).
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
74
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
75 **** Other:
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
76
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
77 -- Any header-file declarations of the sort
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
78
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
79 struct foobar;
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
80
376386a54a3c Import from CVS: tag r19-14
cvs
parents:
diff changeset
81 go into the "types" section of lisp.h.