Mercurial > hg > xemacs-beta
annotate src/README @ 5047:07dcc7000bbf
put width before height consistently, fix a real bug found in the process
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-02-20 Ben Wing <ben@xemacs.org>
* EmacsFrame.c (EmacsFrameRecomputeCellSize):
* faces.c (default_face_font_info):
* faces.c (default_face_width_and_height):
* faces.c (Fface_list):
* faces.h:
* frame-gtk.c (gtk_set_initial_frame_size):
* frame-gtk.c (gtk_set_frame_size):
* frame-gtk.c (gtk_recompute_cell_sizes):
* frame.c:
* frame.c (frame_conversion_internal_1):
* frame.c (change_frame_size_1):
* frame.c (change_frame_size):
* glyphs-msw.c (mswindows_combo_box_instantiate):
* glyphs-widget.c (widget_instantiate):
* glyphs-widget.c (tree_view_query_geometry):
* glyphs-widget.c (Fwidget_logical_to_character_width):
* glyphs-widget.c (Fwidget_logical_to_character_height):
* indent.c (vmotion_pixels):
* redisplay-output.c (get_cursor_size_and_location):
* redisplay-xlike-inc.c (XLIKE_output_eol_cursor):
* redisplay-xlike-inc.c (XLIKE_flash):
* redisplay.c (calculate_baseline):
* redisplay.c (start_with_point_on_display_line):
* redisplay.c (glyph_to_pixel_translation):
* redisplay.c (pixel_to_glyph_translation):
* window.c (margin_width_internal):
* window.c (frame_size_valid_p):
* window.c (frame_pixsize_valid_p):
* window.c (check_frame_size):
* window.c (set_window_pixsize):
* window.c (window_pixel_height_to_char_height):
* window.c (window_char_height_to_pixel_height):
* window.c (window_displayed_height):
* window.c (window_pixel_width_to_char_width):
* window.c (window_char_width_to_pixel_width):
* window.c (change_window_height):
* window.c (window_scroll):
* window.h:
IMPORTANT: Aidan and Carbon Repo, please pay attention and fix
appropriately!
Rename: default_face_height_and_width -> default_face_width_and_height
and reverse width/height arguments.
Reverse width/height arguments to the following functions:
-- default_face_font_info
-- default_face_height_and_width (see above)
-- check_frame_size
-- frame_size_valid_p (made into a static function)
Fix a redisplay bug where args to default_face_height_and_width
were in the wrong order.
| author | Ben Wing <ben@xemacs.org> |
|---|---|
| date | Sat, 20 Feb 2010 18:56:01 -0600 |
| parents | 304aebb79cd3 |
| children | 56144c8593a8 |
| rev | line source |
|---|---|
| 428 | 1 This directory contains the source files for the C component of XEmacs. |
| 2 Nothing in this directory is needed for using XEmacs once it is built | |
| 3 and installed, if the dumped Emacs is copied elsewhere. | |
| 4 | |
| 5 See the files ../README and then ../INSTALL for installation instructions. | |
| 6 | |
| 7 Under Unix, the file `Makefile.in.in' is used as a template by the script | |
| 8 `../configure' to produce `Makefile.in'. The same script then uses `cpp' | |
| 9 to produce the machine-dependent `Makefile' from `Makefile.in'; | |
| 10 `Makefile' is the file which actually controls the compilation of | |
| 11 Emacs. Most of this should work transparently to the user; you should | |
| 12 only need to run `../configure', and then type `make'. | |
| 13 | |
| 14 General changes for XEmacs: | |
| 15 --------------------------- | |
| 16 1. Lisp objects. | |
| 17 | |
| 18 -- XFASTINT has been eliminated. Use of this expression as an lvalue | |
| 19 is incompatible with the union form of Lisp objects, and use as | |
| 20 an rvalue is likely to lead to errors and doesn't really save much | |
| 21 time. Expressions of the form `XFASTINT (obj) = num;' get replaced | |
| 22 by `obj = make_int (num);' or `XSETINT (obj, num);' and | |
| 23 expressions of the form `num = XFASTINT (obj);' get replaced by | |
| 24 `num = XINT (obj);'. Use Qzero in place of `make_int (0)'. | |
| 25 | |
| 26 -- Use of XTYPE gets replaced by the appropriate predicate. Using | |
| 27 XTYPE only works for the small number of types that are not stored | |
| 28 using the Lisp_Record type (int, cons, string, and vector). For | |
| 29 example, `(XTYPE (foo) == Lisp_Buffer)' gets replaced by | |
| 30 `(BUFFERP (foo))'. | |
| 31 | |
| 32 -- `XSET (obj, Lisp_Int, num)' gets replaced by `XSETINT (obj, num)', | |
| 33 for consistency. | |
| 34 | |
| 35 -- Some occurrences of XSET need to get replaced by XSETR -- | |
| 36 specifically, those where the type is not a primitive type | |
| 37 (primitive types are int, cons, string, and vector). | |
| 38 | |
| 39 -- References to `XSTRING (obj)->size' get replaced with | |
| 40 `XSTRING_LENGTH (obj)'. This is currently for cosmetic reasons | |
| 41 but there may be other reasons in the future. (This change is | |
| 42 currently incomplete in the source files.) | |
| 43 | |
| 44 | |
| 45 2. Storage classes: | |
| 46 | |
| 47 -- All occurrences of `register' should be replaced by `REGISTER'. | |
| 48 It interferes with backtraces so we disable it if DEBUG_XEMACS | |
| 49 is defined. | |
| 50 | |
| 51 | |
| 52 3. Errors, messages, I18N3 snarfing: | |
| 53 | |
| 54 -- Errors are continuable in XEmacs but are not in FSF Emacs. | |
| 55 Therefore, it's important that functions do something reasonable | |
| 56 if an error gets continued. If you want to signal a non- | |
| 57 continuable error, the call to Fsignal() gets put inside a | |
| 58 `while (1)' loop. To facilitate this, and also for proper I18N3 | |
| 59 message snarfing, most calls to Fsignal() have been replaced by | |
| 60 calls to signal_error(), signal_simple_error(), etc. Look at | |
| 61 eval.c for a classification of various error functions. | |
| 62 | |
| 63 -- Constant strings occurring in source files need to get wrapped | |
|
4953
304aebb79cd3
function renamings to track names of char typedefs
Ben Wing <ben@xemacs.org>
parents:
442
diff
changeset
|
64 in a call to GETTEXT (or if inside of a call to `build_ascstring', |
| 428 | 65 change that function to `build_translated_string') if they don't |
| 66 occur in certain places where the I18N3 message snarfer will see | |
| 67 them. For a complete discussion of this, see the file | |
| 68 lib-src/make-msgfile.lex. | |
| 69 | |
| 70 NOTE: I18N3 support is not currently working, so the above may | |
| 71 or may not apply. Thus it is not a good idea to add random | |
| 72 GETTEXTs, unless you really know what you are doing. | |
| 73 | |
| 74 -- Calls to `fprintf (stderr, ...)' and `printf (...)' get replaced | |
| 75 with calls to `stderr_out' and `stdout_out'. This is for I18N3 | |
| 76 message snarfing. | |
| 77 | |
| 78 4. Initialization: | |
| 79 | |
| 80 -- FSF constructs like `obj = intern ("string"); staticpro (&obj);' | |
| 81 get replaced by `defsymbol (&obj);'. This is for code cleanness | |
| 82 and better purespace usage. | |
| 83 -- FSF constructs like | |
| 84 obj = intern ("error"); | |
| 85 Fput (obj, Qerror_message, "message"); | |
| 86 Fput (obj, Qerror_conditions, some list); | |
| 87 get replaced by calls to deferror(). See the definition of | |
| 88 deferror() for how the correct arguments to pass. This is for | |
| 89 code cleanness and I18N3 message snarfing. | |
| 90 -- Code in keys_of_foo() functions has been moved into Lisp. |