annotate lisp/post-gc.el @ 5047:07dcc7000bbf

put width before height consistently, fix a real bug found in the process -------------------- ChangeLog entries follow: -------------------- src/ChangeLog addition: 2010-02-20 Ben Wing <ben@xemacs.org> * EmacsFrame.c (EmacsFrameRecomputeCellSize): * faces.c (default_face_font_info): * faces.c (default_face_width_and_height): * faces.c (Fface_list): * faces.h: * frame-gtk.c (gtk_set_initial_frame_size): * frame-gtk.c (gtk_set_frame_size): * frame-gtk.c (gtk_recompute_cell_sizes): * frame.c: * frame.c (frame_conversion_internal_1): * frame.c (change_frame_size_1): * frame.c (change_frame_size): * glyphs-msw.c (mswindows_combo_box_instantiate): * glyphs-widget.c (widget_instantiate): * glyphs-widget.c (tree_view_query_geometry): * glyphs-widget.c (Fwidget_logical_to_character_width): * glyphs-widget.c (Fwidget_logical_to_character_height): * indent.c (vmotion_pixels): * redisplay-output.c (get_cursor_size_and_location): * redisplay-xlike-inc.c (XLIKE_output_eol_cursor): * redisplay-xlike-inc.c (XLIKE_flash): * redisplay.c (calculate_baseline): * redisplay.c (start_with_point_on_display_line): * redisplay.c (glyph_to_pixel_translation): * redisplay.c (pixel_to_glyph_translation): * window.c (margin_width_internal): * window.c (frame_size_valid_p): * window.c (frame_pixsize_valid_p): * window.c (check_frame_size): * window.c (set_window_pixsize): * window.c (window_pixel_height_to_char_height): * window.c (window_char_height_to_pixel_height): * window.c (window_displayed_height): * window.c (window_pixel_width_to_char_width): * window.c (window_char_width_to_pixel_width): * window.c (change_window_height): * window.c (window_scroll): * window.h: IMPORTANT: Aidan and Carbon Repo, please pay attention and fix appropriately! Rename: default_face_height_and_width -> default_face_width_and_height and reverse width/height arguments. Reverse width/height arguments to the following functions: -- default_face_font_info -- default_face_height_and_width (see above) -- check_frame_size -- frame_size_valid_p (made into a static function) Fix a redisplay bug where args to default_face_height_and_width were in the wrong order.
author Ben Wing <ben@xemacs.org>
date Sat, 20 Feb 2010 18:56:01 -0600
parents 75b8038f720e
children d27c1ee1943b 308d34e9f07d
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
886
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
1 ;;; post-gc.el --- post-gc actions
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
2
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
3 ;; Copyright (C) 1985-1986, 1990, 1992-1997 Free Software Foundation, Inc.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
4 ;; Copyright (c) 1993, 1994 Sun Microsystems, Inc.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
5 ;; Copyright (C) 1995 Board of Trustees, University of Illinois
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
6
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
7 ;; Author: Mike Sperber <mike@xemacs.org>
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
8 ;; Maintainer: XEmacs Development Team
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
9 ;; Keywords: internal, dumped
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
10
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
11 ;; This file is part of XEmacs.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
12
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
13 ;; XEmacs is free software; you can redistribute it and/or modify it
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
14 ;; under the terms of the GNU General Public License as published by
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
15 ;; the Free Software Foundation; either version 2, or (at your option)
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
16 ;; any later version.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
17
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
18 ;; XEmacs is distributed in the hope that it will be useful, but
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
19 ;; WITHOUT ANY WARRANTY; without even the implied warranty of
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
20 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
21 ;; General Public License for more details.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
22
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
23 ;; You should have received a copy of the GNU General Public License
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
24 ;; along with XEmacs; see the file COPYING. If not, write to the
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
25 ;; Free Software Foundation, 59 Temple Place - Suite 330,
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
26 ;; Boston, MA 02111-1307, USA.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
27
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
28 ;;; Synched up with: Not in FSF.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
29
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
30 ;;; Commentary:
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
31
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
32 ;; This file is dumped with XEmacs.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
33
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
34 ;; This file defines actions to happen after each GC to perform
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
35 ;; additional cleanup, call finalizers, etc.
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
36
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
37 (defun run-finalizers (alist)
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
38 "Run the finalizers for all objects that have just become unreachable."
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
39 (let ((info (assq 'finalize-list alist)))
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
40 (if info
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
41 (let ((finalize-list (cdr info)))
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
42 (while finalize-list
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
43 (funcall (cdr (car finalize-list)) (car (car finalize-list)))
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
44 (setq finalize-list (cdr finalize-list)))))))
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
45
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
46 (add-hook 'post-gc-hook 'run-finalizers)
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
47
1591
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
48 (defvar simple-finalizer-ephemerons '()
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
49 "List of ephemerons for objects that have a finalizer attached..")
886
011e1bce6ece [xemacs-hg @ 2002-06-28 14:20:41 by michaels]
michaels
parents:
diff changeset
50
1591
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
51 (defun add-finalizer (object func)
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
52 "Add FUNC as a finalizer for object OBJECT."
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
53 (setq simple-finalizer-ephemerons
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
54 (cons (make-ephemeron object object func)
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
55 simple-finalizer-ephemerons)))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
56
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
57 (defun cleanup-simple-finalizers (alist)
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
58 "Clean up `simple-finalizer-ephemerons'."
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
59 ;; We have to do this by hand because DELETE-IF isn't defined yet.
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
60 (let ((current simple-finalizer-ephemerons)
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
61 (prev nil))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
62 (while (not (null current))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
63 (if (not (ephemeron-ref (car current)))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
64 (if (null prev)
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
65 (setq simple-finalizer-ephemerons (cdr current))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
66 (setcdr prev (cdr current)))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
67 (setq prev current))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
68 (setq current (cdr current)))))
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
69
75b8038f720e [xemacs-hg @ 2003-07-26 14:01:23 by michaels]
michaels
parents: 886
diff changeset
70 (add-hook 'post-gc-hook 'cleanup-simple-finalizers)