Mercurial > hg > ietf

comparison draft-ietf-clude-data-model-schema-14_review.txt @ 2:4cda788d7ada

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
historical
author Henry S. Thompson <ht@inf.ed.ac.uk>
date Sat, 21 Oct 2023 16:09:52 +0100
parents
children
comparison
equal deleted inserted replaced
1:92618ff70952 2:4cda788d7ada
1 Document: draft-ietf-clue-data-model-schema
2 Title: An XML Schema for the CLUE data model
3 Reviewer: Henry S. Thompson
4 Review Date: 2016-05-11
5 IETF Last Call Date: 2016-05-23
6
7 Summary: The XML Schema itself which is included in this draft is
8 conformant to the XML Schema 1.0 spec, and is good to go. There is a
9 minor glitch in one of the XML examples, easily corrected.
10
11 Comments:
12
13 I tested the XML Schema document included as section 4 and it passes as
14 a valid against the schema for schemas. The example document in section
15 17 is schema-valid according to the corresponding schema. See 'Nits'
16 below for a minor problem with the example document in section 18.
17
18 I briefly reviewed the schema document and it seems straightforward and
19 fit for its intended purpose.
20
21 Minor Issues:
22
23 Section 4, lines 13--14:
24
25 <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
26 schemaLocation="xcard.xsd"/>
27
28 As this stands, it's not actually usable for validation purposes,
29 because no xcard.xsd file is supplied. Furthermore, there is no
30 Appendix A, which is alleged to provide it (see 11.29.1.2).
31
32 I note further that the xCard RFC (6351) doesn't contain an XSD-format
33 schema document either. The IANA XML Registry [1] schema entry for the
34 urn:ietf:params:xml:ns:vcard-4.0 URN namespace _does_ however link to
35 such a schema document [2]. I suggest you either
36 a) Edit the draft so the above lines read
37
38 <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
39 schemaLocation="http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd"/>
40
41 (this is what I did to do the validity checks I did);
42
43 or
44
45 b) Delete the schemaLocation attribute, add a comment identifying
46 possible sources of a schema document for the vcard-4.0 namespace,
47 e.g. the above iana.org URI or the contents of Appendix A (if you
48 fill it in).
49
50 Nits:
51
52 Section 18, the XML example has a (copy-paste?) error, which renders
53 that example invalid against the schema. The line
54
55 <encGroupIDREF>EG0</encGroupIDREF>
56
57 appears twice inside mediaCapture VC7, once on line 204 and once on line
58 237. The first occurrence should be deleted.
59
60 [1] http://www.iana.org/assignments/xml-registry/xml-registry.xhtml#schema
61 [2] http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd