annotate draft-ietf-sidrops-avoid...txt @ 19:7f1bd15f2d23

getting started
author Henry S. Thompson <ht@inf.ed.ac.uk>
date Tue, 20 Oct 2026 19:49:34 +0100
parents d8dde47d0a7f
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
17
4ca654e435db just the URI
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
1 https://datatracker.ietf.org/doc/draft-ietf-sidrops-avoid-rpki-state-in-bgp/reviewrequest/24139/login/
18
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
2 Document: draft-ietf-sidrops-avoid-rpki-state-in-bgp-11
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
3 Title: Guidance to Avoid Carrying RPKI Validation States in BGP Path Attributes
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
4 Reviewer: Henry S. Thompson
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
5 Review Date: 2025-06-17
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
6
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
7 *Summary*
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
8
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
9 As far as I can tell as a non-specialist, the presentation of this
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
10 proposed BCP is in good shape. There is one minor suggestion and some
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
11 editorial nits below.
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
12
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
13 *Minor point*
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
14
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
15 1.
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
16
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
17 ... "states leak through to EGBP speakers." Would it be possible to
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
18 _briefly_ mention here at least one known way in which such leakage
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
19 can occur in a conformant router? That way operators of 'good'
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
20 routers may realise this document is relevant to them.
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
21
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
22 *Nits*
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
23
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
24 1.
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
25
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
26 In this phrase
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
27
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
28 "Annotating ... Attribute carried across EBGP session (based on validation
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
29 states) means that BGP UPDATE messages have to be sent to every
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
30 neighbor when the aforementioned validation states"
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
31
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
32 there's a minor grammatical problem. I would suggest the following
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
33 change
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
34
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
35 "... Attribute carried across an EBGP session (based on validation
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
36 states) means that BGP UPDATE messages have to be sent to every
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
37 neighbor when the aforementioned validation states"
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
38
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
39 4.
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
40
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
41 "BGP communities" -> "BGP Communities" [here and in 4 other places below]
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
42
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
43 "hold similar" -> "hold in a similar way"
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
44
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
45 4.1
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
46
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
47 "a large amounts" -> "large amounts"
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
48
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
49 4.1.2
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
50
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
51 "caused by operators to signal validation states" ->
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
52 "caused by operators signalling validation states"
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
53
d8dde47d0a7f as submitted?
Henry Thompson <ht@markup.co.uk>
parents: 17
diff changeset
54