Mercurial > hg > ietf

annotate emailcore-review.txt @ 20:7cf0c76e9749

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
hacking away
author Henry S. Thompson <ht@inf.ed.ac.uk>
date Wed, 21 Oct 2026 11:01:35 +0100
parents 8ddd610a05ba
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
9
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
1 Document: draft-ietf-emailcore-rfc5321bis-40
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
2 Intended RFC status: Proposed Standard
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
3 Review type: artart - Last Call review
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
4 Reviewer: Henry S. Thompson
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
5 Review Date: 2025-02-05
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
6 Result: Ready with minor issues
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
7
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
8 *Summary*
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
9
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
10 This is a non-trivial update to a major standard
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
11
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
12 *Substantive points*
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
13
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
14 *Minor points*
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
15
10
8ddd610a05ba missed the deadline, sent to Klensin as is
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 9
diff changeset
16 [Passim]: I realise there's nothing like this in the ancestors of
8ddd610a05ba missed the deadline, sent to Klensin as is
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 9
diff changeset
17 this one, but I really miss not having a single Appendix where the
8ddd610a05ba missed the deadline, sent to Klensin as is
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 9
diff changeset
18 ABNF rules are gathered together, see e.g. RFC 3986 Appendix A.
8ddd610a05ba missed the deadline, sent to Klensin as is
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 9
diff changeset
19
9
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
20 8.1.4:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
21
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
22 I had to do some hunting to understand what was being referred to by
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
23 'Strings' in the last paragraph. Maybe expand this slightly to read
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
24
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
25 As new clauses are defined, they may, in principle, specify
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
26 creation of separate registries (specific to them) if the Strings
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
27 allowed by the syntax summary consist of reserved terms or keywords
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
28 rather than less restricted strings.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
29
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
30 D:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
31 I find the use of the word 'deprecated' in this appendix confusing
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
32 and, it seems to me, inconsistent.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
33
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
34 In the first para., we find
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
35
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
36 "A few features of RFC 821 have proven to be problematic and SHOULD
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
37 NOT be used in Internet mail"
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
38
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
39 So far so good, in my experience of how 'deprecated' is used.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
40
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
41 And in D.1 we find
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
42
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
43 "Its use is deprecated; SMTP systems SHOULD NOT use it unless ..."
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
44
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
45 Also OK by me.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
46
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
47 But in D.4 we find
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
48
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
49 "It is deprecated and MUST NOT be used."
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
50
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
51 In my experience that amounts to a contradiction. Deprecation, I
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
52 thought, is meant for something which the spec. currently allows,
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
53 but is considered to be outdated and probably SHOULD NOT be
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
54 used. Support in future versions cannot be counted on.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
55
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
56 Since the ABNF doesn't allow this, and it hasn't been supported for
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
57 a long time, it's way past time for deprecation, in my opinion. At
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
58 most a note back in 4.1.3 saying that #-literals haven't made sense
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
59 for a long time and MUST NOT be used.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
60
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
61 Similarly in D.5 we find
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
62
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
63 "It is deprecated and MUST NOT be used."
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
64
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
65 Since the ABNF no longer allows anything other than 4-digit years,
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
66 deprecation is not appropriate IMO. It would make sense to me iff
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
67 back in 4.4.5 wording was added saying it SHOULD NOT be produced,
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
68 but MAY be accepted for backward-compatibility for the time being.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
69
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
70 *Nits*
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
71
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
72 8.1.1.3 (1):
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
73 "EHLO Keyword: The textual name of the SMTP service extension"
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
74 Needs a full-stop.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
75
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
76 8.1.3:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
77 '"Additional Registered Clauses (keyword and
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
78 values)' Needs a close-quote.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
79
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
80 8.3.3.2:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
81 '"Additional verbs", "MAIL/RCPT Parameter Values" ...' reads
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
82 awkwardly to me, I'd prefer
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
83 '"Additional verbs" and "MAIL/RCPT Parameter Values" ...'
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
84
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
85 8.3.3.3:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
86 'Note: Implementation support for VRFY is required in servers but
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
87 its listing in the EHLO response is optional".'
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
88 Either spurious close-quote or missing open-quote.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
89
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
90 9:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
91 "chetti contributed" and the long note that precedes it.
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
92 Would "chetti [sic] contributed ..." be a possible compromise? [If
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
93 not, nothing needs to be said, I certainly don't want to require any
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
94 further discussion of what has already consumed more time than it
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
95 deserves.]
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
96
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
97 C.1:
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
98 "by Smith at host bar.com, and to Jones ..."
10
8ddd610a05ba missed the deadline, sent to Klensin as is
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 9
diff changeset
99 Reads awkwardly to me. Just
9
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
100 "by Smith at host bar.com to Jones ..."
052d25a9004a starting with section 8 and Appendices
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
101 seems OK to me.